[DungPham]

Please help me fix this code (the serial process give a true value, but wrong and strange in the parallel processes):

PHP Code:

#include "udf.h"
#include "math.h"
#include "metric.h"
#include "stdio.h"
#include "time.h"
#include "sg_mphase.h"

DEFINE_EXECUTE_AT_END(liquid_holdup)
{
    
    real liquid_vol = 0., cell_vol = 0.;
#if !RP_HOST
    Domain *mix_domain = Get_Domain(1);
    Thread *t;
    Thread **pt;
    cell_t c;
#endif

#if !RP_HOST
    mp_thread_loop_c (t, mix_domain,pt)
    if (FLUID_THREAD_P(t))
    {
        begin_c_loop_int (c,t)
            {
                liquid_vol += C_VOF(c,pt[0])*C_VOLUME(c,t); /*pt[0] is primary phase*/
                cell_vol += C_VOLUME(c,t);
                C_UDMI(c,t,1) = liquid_vol/cell_vol; /*storage the liquid holdup*/
            }
        end_c_loop_int (c,t)
    }
#endif

#if !RP_HOST
    Message("\n_____________The liquid holdup = %g / %g = %g___________\n\n", liquid_vol, cell_vol, liquid_vol/cell_vol);
#endif
} 


Parallel:




Serial:



Thank for reading!

[DungPham]

Woa!

I fixed it successfully!

This is new code:

PHP Code:

DEFINE_EXECUTE_AT_END(liquid_holdup)
{
    int thread_id=0;
    real liquid_vol = 0., cell_vol = 0.;
#if !RP_HOST
    Domain *mix_domain = Get_Domain(1);
    Thread *t;
    Thread **pt;
    cell_t c;
#endif

#if !RP_NODE /* SERIAL or HOST */
    thread_id = RP_Get_Integer("thread-id");
    Message("\nCalculating on Thread # %d\n",thread_id);
#endif /* !RP_NODE */

host_to_node_int_1(thread_id);

#if RP_NODE 
    //Message("\nNode %d is calculating on thread # %d\n",myid,thread_id);
#endif /* RP_NODE */

#if !RP_HOST
    t = Lookup_Thread(mix_domain,thread_id);
    mp_thread_loop_c (t, mix_domain,pt)
    if (FLUID_THREAD_P(t))
        {
            begin_c_loop_int (c,t)
                {
                    liquid_vol += C_VOF(c,pt[0])*C_VOLUME(c,t); /*pt[0] is primary phase*/
                    cell_vol += C_VOLUME(c,t);
                }
            end_c_loop_int (c,t)
                //Message("____liquid_vol: %f\n",liquid_vol);
                //Message("____cell_vol: %f\n",cell_vol);
        }
    # if RP_NODE 
        /* Perform node synchronized actions here.Does nothing in Serial */
        liquid_vol = PRF_GRSUM1(liquid_vol);
        cell_vol = PRF_GRSUM1(cell_vol);
    # endif /* RP_NODE */
#endif

node_to_host_real_2(liquid_vol,cell_vol);

#if !RP_HOST
    t = Lookup_Thread(mix_domain,thread_id);
    mp_thread_loop_c (t, mix_domain,pt)
    if (FLUID_THREAD_P(t))
        {
            begin_c_loop_int (c,t)
                {
                    C_UDMI(c,t,1) = liquid_vol/cell_vol; /*storage the liquid holdup*/
                }
            end_c_loop_int (c,t)
        }
#endif

#if !RP_NODE
    Message("\n_____________The liquid holdup = %g / %g = %g___________\n\n",liquid_vol,cell_vol,liquid_vol/cell_vol);
#endif
}