CFD Online Logo CFD Online URL
www.cfd-online.com
[Sponsors]
Home > Forums > OpenFOAM Bugs

LESProperties and PrandtlDeltaC

Register Blogs Members List Search Today's Posts Mark Forums Read

Reply
 
LinkBack Thread Tools Display Modes
Old   September 2, 2008, 02:45
Default Dear Developers, Just encou
  #1
Member
 
Niklas Wikstrom
Join Date: Mar 2009
Posts: 85
Rep Power: 8
wikstrom is on a distinguished road
Dear Developers,

Just encountered a minor inconsistency:

In LESProperties, conveniently all constants are represented by scalars, however PrandtlDelta performs dimensionedScalar lookups.

OpenFOAM version
1.5.x (Pulled from git repo)

Affected files
$FOAM_SRC/turbulenceModels/LES/LESdeltas/PrandtlDelta/PrandtlDelta.C

Simple Fix:


65c65
< kappa_(dimensionedScalar(dd.lookup("kappa")).value ()),
---
> kappa_(readScalar(dd.lookup("kappa"))),
68,69c68
< dimensionedScalar(dd.subDict(type() + "Coeffs").lookup("Cdelta"))
< .value()
---
> readScalar(dd.subDict(type() + "Coeffs").lookup("Cdelta"))
83,84c82,83
< kappa_ = dimensionedScalar(d.lookup("kappa")).value();
< Cdelta_ = dimensionedScalar(dd.lookup("Cdelta")).value();
---
> kappa_ = readScalar(d.lookup("kappa"));
> Cdelta_ = readScalar(dd.lookup("Cdelta"));



Cheers
Niklas
wikstrom is offline   Reply With Quote

Old   September 2, 2008, 05:19
Default Thanks for the bug-report, the
  #2
Senior Member
 
Join Date: Mar 2009
Posts: 854
Rep Power: 13
henry is on a distinguished road
Thanks for the bug-report, the fix is now in the 1.5.x git repository.

H
henry is offline   Reply With Quote

Old   August 9, 2010, 08:59
Default
  #3
Member
 
Sylvain Aguinaga
Join Date: Feb 2010
Posts: 32
Rep Power: 7
Sylvain is on a distinguished road
It looks like the proposal of Niklas is not present in 1.7.x version as it still looking for dimensionedScalar Lookups.

When I run pisoFoam it is not finding the kappa constant even if I put it in the dictionary, I don't know yet if it is linked. I will try to recompile the code with Niklas proposal. I'm not sure, I'm a bit lost among all those models and C code...

Sincerely

Sylvain
Sylvain is offline   Reply With Quote

Old   August 9, 2010, 09:52
Default
  #4
New Member
 
Andrew Heather
Join Date: Mar 2009
Posts: 16
Rep Power: 8
heather is on a distinguished road
Thanks - I've re-added the code to 1.7.x - should be there the next time you 'git pull'

Andy
heather is offline   Reply With Quote

Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
OF15 functionObjects do not read LESProperties for incompressible flows aunola OpenFOAM Bugs 1 September 28, 2008 17:18


All times are GMT -4. The time now is 18:49.