CFD Online Logo CFD Online URL
www.cfd-online.com
[Sponsors]
Home > Forums > OpenFOAM Bugs

Irritating TYPO in updateFromRepositoryAndCompilesh trashes source

Register Blogs Members List Search Today's Posts Mark Forums Read

Reply
 
LinkBack Thread Tools Display Modes
Old   April 29, 2008, 22:07
Default Description: Ugh. Copies of u
  #1
New Member
 
Andrew Burley
Join Date: Mar 2009
Posts: 4
Rep Power: 8
vonbraun is on a distinguished road
Description:
Ugh. Copies of updateFromRepositoryAndCompile.sh
in both /branches/OpenCFD_Release/OpenFOAM-1.4.1_patch and /branches/OpenCFD_Release/OpenFOAM-1.4_patch have a typo that will ensure your local working copy is useless and WON'T compile:

Reads (in the case of OpenFOAM-1.4.1_patch) on line 5:

svn diff -r30 --diff-cmd diff -x "--unified=7".........

"-r30"?????!!! The file this is in isn't even revision 30. Some untouched files are still Rev 30, but all useful patches are in the triple digits.

Solver/Application:
Since we're after the latest patches submitted to this repo. section, why not use HEAD?

Therefore PATCH LINE 5 of updateFromRepositoryAndCompile.sh
in BOTH OpenFOAM-1.4_patch and OpenFOAM-1.4.1_patch to read:

svn diff -r HEAD --diff-cmd diff -x "--unified=7" https://openfoam-extend......etcetc

Versions:
Affects SVN patch branches:
/branches/OpenCFD_Release/OpenFOAM-1.4.1_patch
/branches/OpenCFD_Release/OpenFOAM-1.4_patch

Notes:
This lil' critter-beast pre-vented a shucsheshful compilatorium on thayt there computah-gizmo-whatzit. Supposin' now I can bes checkin' this 'ere software out somethun speshul-like...
vonbraun is offline   Reply With Quote

Old   April 29, 2008, 22:34
Default Whoops! Made a boo-boo myself:
  #2
New Member
 
Andrew Burley
Join Date: Mar 2009
Posts: 4
Rep Power: 8
vonbraun is on a distinguished road
Whoops! Made a boo-boo myself:

Use:
svn diff -r HEAD:30 --diff-cmd diff -x "--unified=7" https://openfoam-exten....
for 1.4.1_patch and

svn diff -r HEAD:6 --diff-cmd diff -x "--unified=7" https://openfoam-exten....
for 1.4_patch

Sorry, my bad. Think I've got it right now... trying to patch now.. if it doesn't work I'll get the full SVN, but I'll post here to let y'all know how I went...
vonbraun is offline   Reply With Quote

Old   April 30, 2008, 01:05
Default Looks like I got it back-the-f
  #3
New Member
 
Andrew Burley
Join Date: Mar 2009
Posts: 4
Rep Power: 8
vonbraun is on a distinguished road
Looks like I got it back-the-front. Using HEAD:30 just ensured I was at Revision 30. svn log -r HEAD:30 outputs change logs from newest to oldest, whilst 30:HEAD outputs change logs from oldest to newest...

So now I'm trying:
svn diff -r 30:HEAD --diff-cmd diff -x "--unified=7" https://openfoam-exten.....

I'll let you know how I fared...
vonbraun is offline   Reply With Quote

Old   April 30, 2008, 03:23
Default Yep, that seems to have done t
  #4
New Member
 
Andrew Burley
Join Date: Mar 2009
Posts: 4
Rep Power: 8
vonbraun is on a distinguished road
Yep, that seems to have done the trick.
SO: svn diff -r 30 --diff-cmd.......
doesn't update to the latest revision.

in updateFromRepositoryAndCompile.sh :
for 1.4.1_patch:
change: svn diff -r 30 --diff-cmd...
to: svn diff -r 30:HEAD --diff-cmd....

and for 1.4_patch:
change: svn diff -r 6 --diff-cmd...
to: svn diff -r 6:HEAD --diff-cmd...

This essentially says "collect all differences between revision 6 and the HEAD revision, and calculate the diff strings relative to my local source, for the intent of upgrading towards HEAD revision".

Sorry about the mix-up earlier, but now I'm happy and compiling away with the latest HEAD of the bugfix patches.
vonbraun is offline   Reply With Quote

Old   April 30, 2008, 07:40
Default Hi! I was under the impress
  #5
Assistant Moderator
 
Bernhard Gschaider
Join Date: Mar 2009
Posts: 3,915
Rep Power: 40
gschaider will become famous soon enoughgschaider will become famous soon enough
Hi!

I was under the impression that -r 30 implies -r 30:HEAD (at least it works for me). Maybe this is an issue with different versions of the svn-client. I will change this in the svn(as soon as the sourceforge.net comes back online - currently I can't reach it)

Bernhard
__________________
Note: I don't use "Friend"-feature on this forum out of principle. Ah. And by the way: I'm not on Facebook either. So don't be offended if I don't accept your invitation/friend request
gschaider is offline   Reply With Quote

Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
contribution of convective source in total source? Antony Phoenics 4 July 30, 2008 05:15
Volumetric source or Inlet source Kumar CFX 0 May 12, 2008 09:33
Source and Source coefficient Ramcharan CFX 0 February 13, 2008 08:27
SOURCE!-b.c. Louisa FLUENT 0 September 3, 2007 14:07
Mixture-model typo in FLUENT6.2 documentation? George Gerber FLUENT 1 June 19, 2006 12:10


All times are GMT -4. The time now is 05:10.