CFD Online Logo CFD Online URL
www.cfd-online.com
[Sponsors]
Home > Forums > OpenFOAM Bugs

Foam::MULES::implicitSolve

Register Blogs Members List Search Today's Posts Mark Forums Read

Reply
 
LinkBack Thread Tools Display Modes
Old   July 30, 2010, 04:13
Default Foam::MULES::implicitSolve
  #1
Member
 
Luca M.
Join Date: Mar 2009
Location: Luzern, Switzerland
Posts: 59
Rep Power: 8
luca is on a distinguished road
Hi,

taking a look inside the function Foam::MULES::implicitSolve I've noticed that:

the coding from line 168 to 191 seems to be useless.

The lambda variable is initialized by non-null constructor (lines 193, 196) and never correct but than it is used in the limiter function to modify the VOF fluxes (i.e. line 492)

These should affect the solution?

Best Regards

Luca
luca is offline   Reply With Quote

Old   August 2, 2010, 09:59
Default
  #2
Senior Member
 
Join Date: Mar 2009
Posts: 854
Rep Power: 13
henry is on a distinguished road
It would be useful if you specified which OpenFOAM version and file you are looking at.
Guessing that you are using OpenFOAM-1.7.x and looking at file src/finiteVolume/fvMatrices/solvers/MULES/MULESTemplates.C: note that CoLambda is a slicedSurfaceScalarField

H
henry is offline   Reply With Quote

Old   August 3, 2010, 04:05
Default
  #3
Member
 
Luca M.
Join Date: Mar 2009
Location: Luzern, Switzerland
Posts: 59
Rep Power: 8
luca is on a distinguished road
Hi Henry,

yes I referred to 1.7.x version. You are right I've noticed that sliced use a reference in the constructor so also if Cof is defined inside the scope all is coherent.

Thank you very much for your reply

Luca
luca is offline   Reply With Quote

Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On



All times are GMT -4. The time now is 05:50.