CFD Online URL
[Sponsors]
Home > Forums > OpenFOAM Programming & Development

function of volMesh class

Register Blogs Members List Search Today's Posts Mark Forums Read

Reply
 
LinkBack Thread Tools Display Modes
Old   July 6, 2011, 11:26
Default function of volMesh class
  #1
Senior Member
 
Kathrin Kissling
Join Date: Mar 2009
Location: Besigheim, Germany
Posts: 134
Rep Power: 7
kathrin_kissling is on a distinguished road
Hi!

In the finiteVolume method the volMesh class can be found, which is derived from GeoMesh.

Code:
class volMesh
:
    public GeoMesh<fvMesh>
{

public:

    // Constructors

        //- Construct from fvMesh
        explicit volMesh(const fvMesh& mesh)
        :
            GeoMesh<fvMesh>(mesh)
        {}


    // Member Functions

        //- Return size
        label size() const
        {
            return size(mesh_);
        }

        //- Return size
        static label size(const Mesh& mesh)
        {
            return mesh.nCells();
        }

        //- Return cell centres
        const volVectorField& C()
        {
            return mesh_.C();
        }
};
Obviously it adds the function size, which is not present in fvMesh class. But instead of just doing
Code:
        label size() const
        {
            return mesh_.nCells();
        }
the above mentioned is done. So now my question is why go generic before actually doing the operation? I'm really sure I'm missing something.

I hope someone can help!

Best

Kathrin
kathrin_kissling is offline   Reply With Quote

Old   July 6, 2011, 12:40
Default
  #2
Senior Member
 
Sandeep Menon
Join Date: Mar 2009
Location: Amherst, MA
Posts: 369
Rep Power: 14
deepsterblue will become famous soon enough
Convenience, perhaps.

The size(const Mesh&) member is a static function that doesn't require an actual object of the class to be instantiated, so it's good from the stand-point of efficiency. When the size() function is called, there is an implicit assumption that an object _does_ actually exist, and that the reference to mesh_ is valid. So therefore, re-use the other function!
__________________
Sandeep Menon
University of Massachusetts Amherst
https://github.com/smenon
deepsterblue is offline   Reply With Quote

Old   July 7, 2011, 06:56
Default
  #3
Senior Member
 
Tomislav Maric
Join Date: Mar 2009
Location: Darmstadt, Germany
Posts: 251
Blog Entries: 5
Rep Power: 10
tomislav_maric is on a distinguished road
Quote:
Originally Posted by deepsterblue View Post
Convenience, perhaps.

The size(const Mesh&) member is a static function that doesn't require an actual object of the class to be instantiated, so it's good from the stand-point of efficiency. When the size() function is called, there is an implicit assumption that an object _does_ actually exist, and that the reference to mesh_ is valid. So therefore, re-use the other function!
Hi Sandeep!

Thanks a LOT for the answer, but I'm not sure that it works like that...

Code:
static label size(const Mesh& mesh)
{
            return mesh.nCells();
}
This means that a reference to a Mesh& has to exist (object has to exist!) and it has to be primitiveMesh or its child, because primitiveMesh implements the nCells() method. "Mesh" comes from GeoMesh, where it is typedefed from MESH, which is a template of GeoMesh. This is also weird...

Code:
template <class MESH>
class GeoMesh

... 

typedef MESH Mesh;  

...
So basically, although MESH can be faMesh, fvMesh, etc, but for the volMesh, it can only be primitiveMesh or fvMesh, because of the nCells(), so the object exists.

Also, typedef should be used to shorten names which are complicated for better use, like the volScalarField from GeometricField<blah, blah>... why Mesh from MESH?

There's a lot of weird stuff down below in the code, I think.
tomislav_maric is offline   Reply With Quote

Old   July 7, 2011, 09:49
Default
  #4
Senior Member
 
Sandeep Menon
Join Date: Mar 2009
Location: Amherst, MA
Posts: 369
Rep Power: 14
deepsterblue will become famous soon enough
Quote:
Originally Posted by tomislav_maric View Post

Code:
static label size(const Mesh& mesh)
{
    return mesh.nCells();
}
This means that a reference to a Mesh& has to exist (object has to exist!) and it has to be primitiveMesh or its child, because primitiveMesh implements the nCells() method. "Mesh" comes from GeoMesh, where it is typedefed from MESH, which is a template of GeoMesh. This is also weird...
I'm not talking about the reference to Mesh& (which, of course, must be valid for the static function to work properly), but the reference: const MESH& mesh_; which is a protected member of the GeoMesh class - _that_ has to be valid for the label size() function to work.

I also meant that an object of the volMesh class does not need to exist for the static label size(const Mesh& mesh) function to work - so my theory still stands.

I agree that the Mesh& reference must be either a primitiveMesh or its derivative, because this is a volMesh, whose intent is to ensure that variables are stored at cells. In contrast, take a look at the equivalent function in pointMesh.H, which stores variables at mesh points, or the areaMesh class in the finiteArea library, which stores them at patch-faces.

Things like this are particularly important during the mesh-to-mesh mapping stage, where sizes need to match, depending on the location of the mesh where variables are stored, and yet they must be generic enough to work for all types of meshes - take a look at MapGeometricFields.H to see how this mechanism works.

Hope this helps.
__________________
Sandeep Menon
University of Massachusetts Amherst
https://github.com/smenon
deepsterblue is offline   Reply With Quote

Old   July 19, 2011, 09:09
Default
  #5
Senior Member
 
Tomislav Maric
Join Date: Mar 2009
Location: Darmstadt, Germany
Posts: 251
Blog Entries: 5
Rep Power: 10
tomislav_maric is on a distinguished road
Hi Sandeep,

the forum settings were set for my previous e-mail.

It's used for mapping and the sizes need to correspond. Thanks!

MESH and Mesh are equivalent types, which kind of confused me (don't know why, don't ask):

Code:
 56         const MESH& mesh_;
 57 
 58 
 59 public:
 60 
 61     // Public typedefs
 62 
 63         typedef MESH Mesh;
Of course, since the method is static it can be called without the object of volMesh being defined, but there has to be some Mesh to get the size from. I just had no idea that this is used for mapping, I only figured that the GeoMesh is a kind of a template wrapper for various types of meshes. Thanks a lot again!
tomislav_maric is offline   Reply With Quote

Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
Compile problem ivanyao OpenFOAM Running, Solving & CFD 1 October 12, 2012 10:31
latest OpenFOAM-1.6.x from git failed to compile phsieh2005 OpenFOAM Bugs 25 February 9, 2010 05:37
Error with Wmake skabilan OpenFOAM Installation 3 July 28, 2009 01:35
Errors running allwmake in OpenFOAM141dev with WM_COMPILE_OPTION%3ddebug unoder OpenFOAM Installation 11 January 30, 2008 21:30
Axisymmetrical mesh Rasmus Gjesing (Gjesing) OpenFOAM Native Meshers: blockMesh 10 April 2, 2007 15:00


All times are GMT -4. The time now is 07:55.