[jzheng]

Hi all,

I am using OF3.0 to recompile a solver that it was written under OF231.

The solver is good in OF231, but it encountered a problem when compiling with OF3.0 since the system always tells me a error like this:
---------------------------------
/opt/openfoam30/src/finiteVolume/lnInclude/readTimeControls.H: In function ‘int main(int, char**)’:

/opt/openfoam30/src/finiteVolume/lnInclude/readTimeControls.H:32:1: error: ‘adjustTimeStep’ was not declared in this scope

/opt/openfoam30/src/finiteVolume/lnInclude/readTimeControls.H:35:1: error: ‘maxCo’ was not declared in this scope

/opt/openfoam30/src/finiteVolume/lnInclude/readTimeControls.H:38:1: error: ‘maxDeltaT’ was not declared in this scope
----------------------------------

The header files in my solver now look like this:
.
.
.
int main(int argc, char *argv[])
{

#include "setRootCase.H"
#include "createTime.H"
#include "createMeshes.H"

#include "readSurfaceFlowProperties.H"

#include "createSurfaceFields.H"
#include "createSubsurfaceFields.H"

#include "readCoupledSolutionControls.H"

#include "createInterpolator.H"

// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //

Info<< "\nStarting time loop\n" << endl;

while (runTime.run())
{
#include "readTimeControls.H"
#include "CourantNo.H"
#include "setDeltaT.H"
.
.
.

My controlDict has the following lines attached:
============================
adjustTimeStep yes;
maxCo 0.5;
maxDeltaT 1E-3;

And my problem is how can I correct this missing declaration?

[arsalan.dryi]

Hi jzheng

Modify your solver as follows:

Info<< "\nStarting time loop\n" << endl;

while (runTime.run())	
{	
const bool adjustTimeStep =
    runTime.controlDict().lookupOrDefault("adjustTimeStep", false);

scalar maxCo =
    runTime.controlDict().lookupOrDefault<scalar>("maxCo", 1.0);

scalar maxDeltaT =
    runTime.controlDict().lookupOrDefault<scalar>("maxDeltaT", GREAT);	
#include "CourantNo.H"
#include "setDeltaT.H"

Regards,
Arsalan.

[jzheng]

Hi Arsalan

Thanks for the hints, and it works. May I ask how this could happen? I noticed the difference of the "readTimeControls" head file between OF231 and OF30 is that OF30 canceled all of the data type of these three parameters: adjustTimeStep, maxCo, maxDeltaT.

Thanks

[Jaime Castañeda]

Hi all,

I am using (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 Copyright (C) 2017 Free Software Foundation, Inc. I am getting errors when compiled in OpenFOAM.

The error messages are attached:
error: ‘adjustTimeStep’ was not declared in this scope
error: ‘maxCo’ was not declared in this scope
error: ‘maxDeltaT’ was not declared in this scope


The header files in the solver are from the RichardsFoam equation.

int main(int argc, char *argv[])
{
#include "setRootCase.H"
#include "createTime.H"
#include "createMesh.H"
#include "createFields.H"
#include "initContinuityErrs.H"

#include "readTimeControls.H"

#include "readPicardControls.H"
...
...
...
...
Info<< "\nStarting time loop\n" << endl;

// starting of the time loop.
while (runTime.loop())
{

// time step control operations.
#include "readTimeControls.H"
#include "setDeltaT.H"

Info<< "Time = " << runTime.timeName() << nl << endl;

...
...
...
...
My controlDict has the following lines attached:
============================
application porousUnsaturatedFoam;

startFrom startTime;

startTime 0;

stopAt endTime;

endTime 86400;

deltaT 300;

writeControl adjustableRunTime;

writeInterval 7200;

purgeWrite 0;

writeFormat ascii;

writePrecision 6;

writeCompression uncompressed;

timeFormat general;

timePrecision 6;

runTimeModifiable yes;

adjustTimeStep yes;

maxDeltaT 3600;

functions
(
probes1
{
type probes; // Type of functionObject
// Where to load it from (if not already in solver)
functionObjectLibs ("libsampling.so");
probeLocations // Locations to be probed. runTime modifiable!
(
(0.5 0.5 1.)
);
// Fields to be probed. runTime modifiable!
fields
(
U
);
}
);


libs ( "libOpenFOAM.so" );
libs ("libuserBCs.so");

and fv solution

Picard
{
nIterPicard 10;
nMaxCycle 10;
stabilisationThreshold 10;
precPicard 1e-4;
tFact 1.3;
}


please can someone explain to me what's going on? Thank you very much

[Jamessmp23]

Your time step "DeltaT" is really large. In my field that large is an unreasonable step size.