CFD Online Discussion Forums - typo in programmers guide? about su and sp

CFD Online Discussion Forums (https://www.cfd-online.com/Forums/)

- OpenFOAM (https://www.cfd-online.com/Forums/openfoam/)

- - typo in programmers guide? about su and sp (https://www.cfd-online.com/Forums/openfoam/150206-typo-programmers-guide-about-su-sp.html)

typo in programmers guide? about su and sp

Hi guys,

In PG, page 37, we have this:

Code:

The implicit source term changes the coefficient of the diagonal of

the matrix. Depending on the sign of the coefficient and matrix terms, this will

either increase or decrease diagonal dominance of the matrix. Decreasing the di-

agonal dominance could cause instability during iterative solution of the matrix

equation. Therefore OpenFOAM provides a mixed source discretisation procedure

that is implicit when the coefficients that are greater than zero, and explicit for the

coefficients less than zero.

Is this a typo? Shouldnt it be:

Code:

that is implicit when the coefficients that are less than zero, and explicit for the

coefficients greater than zero.

Thanks.

Sorry, I mistyped it in the heading....thats a really typo.............

Quote:

Originally Posted by sharonyue (Post 536815)

Hi guys,

In PG, page 37, we have this:

Code:

The implicit source term changes the coefficient of the diagonal of

the matrix. Depending on the sign of the coefficient and matrix terms, this will

either increase or decrease diagonal dominance of the matrix. Decreasing the di-

agonal dominance could cause instability during iterative solution of the matrix

equation. Therefore OpenFOAM provides a mixed source discretisation procedure

that is implicit when the coefficients that are greater than zero, and explicit for the

coefficients less than zero.

Is this a typo? Shouldnt it be:

Code:

that is implicit when the coefficients that are less than zero, and explicit for the

coefficients greater than zero.

Thanks.

Sorry, I mistyped it in the heading....thats a really typo.............

Dear sharonyue,

I completely agree on this, Thank you for highlighting it

:)
-
Best Regards!

Greetings to all!

@sharonyue: I fixed the typo on the thread title for you ;) (type -> typo)

You should have stated which version of the Programmer's Guide you're referring to, because in 2.3.x it's page 39.
From what I can figure out, the issue in question is in subsection "2.4.9 Source terms".

Which brings up the question: what is your basis for your statement? Or in other words, where in the source code did you see this?

Best regards,
Bruno