CFD Online Logo CFD Online URL
www.cfd-online.com
[Sponsors]
Home > Forums > OpenFOAM

typo in programmers guide? about su and sp

Register Blogs Members List Search Today's Posts Mark Forums Read

Reply
 
LinkBack Thread Tools Display Modes
Old   March 17, 2015, 13:23
Default typo in programmers guide? about su and sp
  #1
Senior Member
 
Dongyue Li
Join Date: Jun 2012
Location: Torino, Italy
Posts: 675
Rep Power: 8
sharonyue is on a distinguished road
Hi guys,

In PG, page 37, we have this:

Code:
The implicit source term changes the coefficient of the diagonal of
the matrix. Depending on the sign of the coefficient and matrix terms, this will
either increase or decrease diagonal dominance of the matrix. Decreasing the di-
agonal dominance could cause instability during iterative solution of the matrix
equation. Therefore OpenFOAM provides a mixed source discretisation procedure
that is implicit when the coefficients that are greater than zero, and explicit for the
coefficients less than zero.
Is this a typo? Shouldnt it be:

Code:
that is implicit when the coefficients that are less than zero, and explicit for the
coefficients greater than zero.
Thanks.


Sorry, I mistyped it in the heading....thats a really typo.............
sharonyue is offline   Reply With Quote

Old   March 19, 2015, 01:42
Default
  #2
Senior Member
 
Tushar Chourushi
Join Date: Jul 2009
Location: IIT-Indore, India
Posts: 318
Blog Entries: 1
Rep Power: 9
Tushar@cfd is on a distinguished road
Quote:
Originally Posted by sharonyue View Post
Hi guys,

In PG, page 37, we have this:

Code:
The implicit source term changes the coefficient of the diagonal of
the matrix. Depending on the sign of the coefficient and matrix terms, this will
either increase or decrease diagonal dominance of the matrix. Decreasing the di-
agonal dominance could cause instability during iterative solution of the matrix
equation. Therefore OpenFOAM provides a mixed source discretisation procedure
that is implicit when the coefficients that are greater than zero, and explicit for the
coefficients less than zero.
Is this a typo? Shouldnt it be:

Code:
that is implicit when the coefficients that are less than zero, and explicit for the
coefficients greater than zero.
Thanks.


Sorry, I mistyped it in the heading....thats a really typo.............
Dear sharonyue,

I completely agree on this, Thank you for highlighting it


-
Best Regards!
__________________
Mistakes Are Inevitable, You Can Only Grow Stronger If You Lean From Them
Tushar@cfd is offline   Reply With Quote

Old   March 21, 2015, 08:50
Default
  #3
Super Moderator
 
Bruno Santos
Join Date: Mar 2009
Location: Lisbon, Portugal
Posts: 8,301
Blog Entries: 34
Rep Power: 84
wyldckat is just really nicewyldckat is just really nicewyldckat is just really nicewyldckat is just really nice
Greetings to all!

@sharonyue: I fixed the typo on the thread title for you (type -> typo)

You should have stated which version of the Programmer's Guide you're referring to, because in 2.3.x it's page 39.
From what I can figure out, the issue in question is in subsection "2.4.9 Source terms".

Which brings up the question: what is your basis for your statement? Or in other words, where in the source code did you see this?

Best regards,
Bruno
wyldckat is offline   Reply With Quote

Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On



All times are GMT -4. The time now is 04:46.