CFD Online Logo CFD Online URL
www.cfd-online.com
[Sponsors]
Home > Forums > SU2

Extraneous pow() computations

Register Blogs Members List Search Today's Posts Mark Forums Read

Reply
 
LinkBack Thread Tools Display Modes
Old   March 8, 2014, 13:38
Default Extraneous pow() computations
  #1
New Member
 
Gaetan Kenway
Join Date: Aug 2013
Posts: 2
Rep Power: 0
gkenway is on a distinguished road
There are two extraneous pow() computations in solver_mean_direct.cpp in the venkatakrishan limiter at lines 4395 and 4414.

/*-- Get limiter parameters from the configuration file ---*/
dave = config->GetRefElemLength();
LimK = config->GetLimiterCoeff();
eps2 = pow((LimK*dave), 3.0);

You take about a 20% speed hit from this. This computation should be outside the edge loop.

Gaetan
gkenway is offline   Reply With Quote

Old   March 10, 2014, 17:09
Default
  #2
Super Moderator
 
Francisco Palacios
Join Date: Jan 2013
Location: Long Beach, CA
Posts: 342
Rep Power: 6
fpalacios is on a distinguished road
Quote:
Originally Posted by gkenway View Post
There are two extraneous pow() computations in solver_mean_direct.cpp in the venkatakrishan limiter at lines 4395 and 4414.

/*-- Get limiter parameters from the configuration file ---*/
dave = config->GetRefElemLength();
LimK = config->GetLimiterCoeff();
eps2 = pow((LimK*dave), 3.0);

You take about a 20% speed hit from this. This computation should be outside the edge loop.

Gaetan
Thanks for letting us know, we have fixed this issue in the current GitHub version. In the future we will appreciate if you use GitHub https://github.com/su2code/SU2/issues to report the issues.

Best,
Francisco
fpalacios is offline   Reply With Quote

Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
Compile problem ivanyao OpenFOAM Running, Solving & CFD 1 October 12, 2012 09:31
Error when doing the computations libra OpenFOAM 4 February 23, 2012 22:30
Computations with eighty million cells Armin OpenFOAM 8 January 7, 2011 15:15
Computations with eighty million cells Armin Main CFD Forum 0 December 28, 2010 07:47
Pos-processing computations Renato Main CFD Forum 0 September 30, 2005 10:35


All times are GMT -4. The time now is 02:00.