blockMesh - no spellcheck at convertToMeters;

seav · November 21, 2014, 14:03

Hello.

Today I've sadly discovered there is no spellcheck at function convertToMeters; in blockMeshDict dictionary file.

BlockMesh just read it anyway without any error or information.
ex. converToMeters 0.001; will be read by blockMesh and it wont be actually converted to 0.001 scale.

...otherwise convertToMeters 0.001; will be read too but it will convert to correct scale.

This is in my opinion an error which can give very very bad informations. And can make confusions especially with new users.

Cheers.
seav

hjasak · November 22, 2014, 16:07

Do you have any ideas on how to actually implement this?

seav · November 22, 2014, 17:11

Hello Mr Jasak,

In my opinion simple spellcheck a phrase "convertToMeters" before blockMesh does his job should be enough. If the phrase is correct blockMesh should go on and if its not should crash with an error.

Sadly admit, I am not skilled with OpenFOAM programing to give source code.

Cheers,
seav.

alexeym · November 22, 2014, 17:15

Well

guess it's a test, change

Code:

    // optional 'convertToMeters' or 'scale'  scaling factor
    if (!meshDescription.readIfPresent("convertToMeters", scaleFactor_))
    {
        meshDescription.readIfPresent("scale", scaleFactor_);
    }

to more strict calls.

wyldckat · January 3, 2015, 06:24

Greetings to all!

This feature request has now been posted at the following locations:

Best regards,
Bruno

seav · January 3, 2015, 06:49

Hi,

Thank you for replay.

Cheers,
seav

derekm · January 3, 2015, 14:18

if you change the first character t of converttToMeters o a capital C you get an access violation... took a wee while to work that one out.

wyldckat · January 3, 2015, 15:08

Quote:

Originally Posted by derekm

if you change the first character t of converttToMeters o a capital C you get an access violation... took a wee while to work that one out.

I'm unable to reproduce that error. I've tried with OpenFOAM 2.3, 2.1, foam-extend 3.1 and OpenFOAM 1.6-ext, using:

converCToMeters
ConvertToMeters
converttToMeters

Can you provide an exact example file and with which OpenFOAM version you managed to get that?

derekm · January 3, 2015, 16:58

Quote:

Originally Posted by wyldckat

I'm unable to reproduce that error. I've tried with OpenFOAM 2.3, 2.1, foam-extend 3.1 and OpenFOAM 1.6-ext, using:

converCToMeters
ConvertToMeters
converttToMeters

Can you provide an exact example file and with which OpenFOAM version you managed to get that?

I'll try to recreate it.. I was just so glad to get rid of the bug I dropped the file pronto ... it was 2.3.1 on OpenSuse 12.3

derekm · January 10, 2015, 18:31

nope cant recreate it...
drat..

November 21, 2014, 14:03	blockMesh - no spellcheck at convertToMeters;	#1
seav Member Join Date: May 2013 Posts: 51 Rep Power: 12	Hello. Today I've sadly discovered there is no spellcheck at function convertToMeters; in blockMeshDict dictionary file. BlockMesh just read it anyway without any error or information. ex. converToMeters 0.001; will be read by blockMesh and it wont be actually converted to 0.001 scale. ...otherwise convertToMeters 0.001; will be read too but it will convert to correct scale. This is in my opinion an error which can give very very bad informations. And can make confusions especially with new users. Cheers. seav __________________ Cheers, seav "OpenFOAM is like a strict teacher, won't let you through until all is correct or better say until one has understood the sensitivities of a problem." -jaswi

November 22, 2014, 16:07		#2
hjasak Senior Member Hrvoje Jasak Join Date: Mar 2009 Location: London, England Posts: 1,905 Rep Power: 33	Do you have any ideas on how to actually implement this? __________________ Hrvoje Jasak Providing commercial FOAM/OpenFOAM and CFD Consulting: http://wikki.co.uk

November 22, 2014, 17:11		#3
seav Member Join Date: May 2013 Posts: 51 Rep Power: 12	Hello Mr Jasak, In my opinion simple spellcheck a phrase "convertToMeters" before blockMesh does his job should be enough. If the phrase is correct blockMesh should go on and if its not should crash with an error. Sadly admit, I am not skilled with OpenFOAM programing to give source code. Cheers, seav. __________________ Cheers, seav "OpenFOAM is like a strict teacher, won't let you through until all is correct or better say until one has understood the sensitivities of a problem." -jaswi

November 22, 2014, 17:15		#4
alexeym Senior Member Alexey Matveichev Join Date: Aug 2011 Location: Nancy, France Posts: 1,930 Rep Power: 38	Well guess it's a test, change Code: // optional 'convertToMeters' or 'scale' scaling factor if (!meshDescription.readIfPresent("convertToMeters", scaleFactor_)) { meshDescription.readIfPresent("scale", scaleFactor_); } to more strict calls. seav likes this.

January 3, 2015, 06:24		#5
wyldckat Retired Super Moderator Bruno Santos Join Date: Mar 2009 Location: Lisbon, Portugal Posts: 10,974 Blog Entries: 45 Rep Power: 128	Greetings to all! This feature request has now been posted at the following locations: http://www.openfoam.org/mantisbt/view.php?id=1473 http://sourceforge.net/p/openfoam-ex...ndrelease/264/ Best regards, Bruno

January 3, 2015, 06:49		#6
seav Member Join Date: May 2013 Posts: 51 Rep Power: 12	Hi, Thank you for replay. Cheers, seav __________________ Cheers, seav "OpenFOAM is like a strict teacher, won't let you through until all is correct or better say until one has understood the sensitivities of a problem." -jaswi

January 3, 2015, 14:18		#7
derekm Senior Member Derek Mitchell Join Date: Mar 2014 Location: UK, Reading Posts: 172 Rep Power: 13	if you change the first character t of converttToMeters o a capital C you get an access violation... took a wee while to work that one out. __________________ A CHEERING BAND OF FRIENDLY ELVES CARRY THE CONQUERING ADVENTURER OFF INTO THE SUNSET

January 10, 2015, 18:31		#10
derekm Senior Member Derek Mitchell Join Date: Mar 2014 Location: UK, Reading Posts: 172 Rep Power: 13	nope cant recreate it... drat.. __________________ A CHEERING BAND OF FRIENDLY ELVES CARRY THE CONQUERING ADVENTURER OFF INTO THE SUNSET

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Is Playstation 3 cluster suitable for CFD work	hsieh	OpenFOAM	9	August 16, 2015 14:53
[blockMesh] set of xyz data in blockMesh	psk	OpenFOAM Meshing & Mesh Conversion	12	August 27, 2013 08:37
Blockmesh problem with more than one block	sven82	OpenFOAM Pre-Processing	1	June 4, 2013 17:08
Dimensionsproblems SLT-file and blockMesh	suitup	OpenFOAM Bugs	3	November 19, 2009 03:00
Blockmesh cavity error message	tonitoney	OpenFOAM Installation	2	March 17, 2008 11:59