[alberto]

I thought to collect the correction to the bugs found up to now in OpenFOAM 1.4, to facilitate their correction.

Here there are a short description of the problem solved by this cumulative patch and the instruction on how to use it.

Date : June 11th, 2007
Applies to : OpenFOAM 1.4

Description : This package is a cumulative patch to solve the issue found till
now in OpenFOAM 1.4. The resolved bugs are listed below:

- Serious bug in backwardDdtScheme
http://www.cfd-online.com/OpenFOAM_D...tml?1180777044
- Minor bug in CrankNicholsonDdtScheme
http://www.cfd-online.com/OpenFOAM_D...tml?1179849129
- Problem of compilation. OF 1.4:Allwmake: command not found
http://www.cfd-online.com/OpenFOAM_D...tml?1178802602
- Recursive "wmake all" doesn't find "Allwmake"
http://www.cfd-online.com/OpenFOAM_D...tml?1176898510
- Failed dimensional check with dynamic LES models
http://www.cfd-online.com/OpenFOAM_D...tml?1181588437

Installation instruction
------------------------

1. Extract the tgz archive with the command:

tar xzf OpenFOAM-1.4-patches-11_june_2007

2. Copy the directory "OpenFOAM-1.4" over your OpenFOAM-1.4 directory and accept
to overwrite the files when the system will ask you to do so.

For example, if you installed OpenFOAM in /home/you_user_name/OpenFOAM/, just
copy the OpenFOAM-1.4 provided with this cumulative patch in that directory.

3. Recompile OpenFOAM using the following commands:

foam
cd src
./Allwmake
cd ../applications
./Allwmake

OpenFOAM-1.4-patches-11_june_2007.tgz

I hope this helps,
Alberto

[benru]

I try to recompile (as prescribed higher) and see:

OpenFOAM/OpenFOAM-1.4/src$ ./Allwmake
+ cd OpenFOAM/OpenFOAM-1.4/src/OpenFOAM
+ wmakeLnInclude .
+ wmake libso zlib-1.2.1
`OpenFOAM/OpenFOAM-1.4/lib/linuxGcc4DPOpt/libz.so' is up to date.
+ wmake libso foamUser
`OpenFOAM/OpenFOAM-1.4/lib/linuxGcc4DPOpt/libfoamUser.so' is up to date.
+ '[' LAM = OPENMPI -a '!' -r /lib/libmpi.a -a '!' -r /lib/libmpi.so ']'
+ '[' LAM = LAM -a '!' -r /OpenFOAM/OpenFOAM-1.4/src/lam-7.1.2/platforms/linuxGcc4DPOpt/lib/libmpi.a -a '!' -r /OpenFOAM/OpenFOAM-1.4/src/
lam-7.1.2/platforms/linuxGcc4DPOpt/lib/libmpi.so ']'
+ '[' LAM = MPICH -a '!' -r /lib/libmpich.a -a '!' -r /lib/libmpich.so ']'
+ cd Pstream
+ ./Allwmake
+ wmake libso dummy
`/OpenFOAM/OpenFOAM-1.4/lib/linuxGcc4DPOpt/dummy/libPstream.so' is up
to date.
+ '[' LAM = LAM -o LAM = OPENMPI -o LAM = MPI -o LAM = MPICH -o LAM = MPICH-GM ']'
+ export WM_OPTIONS=linuxGcc4DPOptLAM
+ WM_OPTIONS=linuxGcc4DPOptLAM
+ wmake libso mpi
`/OpenFOAM/OpenFOAM-1.4/lib/linuxGcc4DPOpt/lam-7.1.2/libPstream.so' i
s up to date.
+ wmake libso OpenFOAM
SOURCE=global/global.C ; g++ -m32 -Dlinux -DDP -Wall -Wno-strict-aliasing -Wextra -Wno
-unused-parameter -Wold-style-cast -O3 -DNoRepository -ftemplate-depth-40 -DWM_PROJECT
_VERSION='"'1.4'"' -I/OpenFOAM/OpenFOAM-1.4/src/zlib-1.2.1 -IlnInclud
e -I. -I/OpenFOAM/OpenFOAM-1.4/src/OpenFOAM/lnInclude -fPIC -pthrea
d -c $SOURCE -o Make/linuxGcc4DPOpt/global.o
In file included from global/global.C:61:
lnInclude/error.C:46:22: error: demangle.h: No such file or directory
lnInclude/error.C: In static member function 'static void Foam::error::printStack(Foam:
stream&)':
lnInclude/error.C:398: error: 'auto_demangling' was not declared in this scope
lnInclude/error.C:399: error: 'cplus_demangle' was not declared in this scope
make: *** [Make/linuxGcc4DPOpt/global.o] Error 1

Is the file demangle.h absent, and where it should be ? NEED HELP !

[gschaider]

Hi Ruben!

The missing of the demangle.h on non-OpenSUSE has been discussed before (use the search engine to find a solution). As an alternative (a demangle-less error.C) try the one published at http://openfoamwiki.net/index.php/Ho...e_OpenFOAM_Mac (it should work for Linux, too). Maybe I already posted it to the board. Can't remember.

[alberto]

While recompiling applications, you also get an error when building PVFoamReader.

Just skip it and manually recompile the remaining directories (preProcessing, surface, thermoPhysical) by entering into them and using wmake all.

Regards,
A.

[benru]

2 Bernhard & Alberto - many big thanks !

May be OpenFOAM/OpenFOAM-1.4/src/OpenFOAM/db/error/error.C & your advices add to patch & README file in one - because without them make new code is not possible ?

Best regards Ruben

[alberto]

It is a distribution-specific issue, so it's better to do two packages, I think.

Where can I get the working error.C file for non-SuSE distributions?

Regards,
A.

[gschaider]

Hi Alberto!

On the Wiki-page mentioned above. That error.C works with MacOSX and Linux (tested on Redhat)

(But you can always install binutils-debug to make the stock error.C work with your distribution)

Bernhard

[alberto]

Thanks Bernhard!

OK. Considering there's a solution for the specific distribution, I would prefer to leave this out of the patch package.

Moreover I find Novell SLE/openSUSE a lot more user friendly than Red Hat/Fedora, and I think it should be the platform of choice for OpenFOAM users :-)

With kind regards,
Alberto

[benru]

As I tried, changed error.C needs for RedHat/Fedora, Debian, Ubuntu distributions, and only openSUSE has no problem. It seems to me, that it shoud be added (with corresponded commentaries) to patch.

Regards
Ruben

[benru]

After successful compilation of /src directory I tried to recompile /applications directory and was stopped with :

r117-1penFOAM/OpenFOAM-1.4/applications$./Allwmake
+ cd solvers
+ wmake all
make[1]: Entering directory `OpenFOAM/OpenFOAM-1.4/applications/solvers/compressible'
make[2]: Entering directory `OpenFOAM/OpenFOAM-1.4/applications/solvers/compressible/rhoSimpleFoam'
g++ -m32 -Dlinux -DDP -Wall -Wno-strict-aliasing -Wextra -Wno-unused-parameter -Wold-style-cast -O3 -DNoRepository -ftemplate-depth-40 -IOpenFOAM/OpenFOAM-1.4/src/finiteVolume/cfdTools -IOpenFOAM/OpenFOAM-1.4/src/finiteVolume/lnInclude -IOpenFOAM/OpenFOAM-1.4/src/thermophysicalModels/basic/lnInclude -IOpenFOAM/OpenFOAM-1.4/src/turbulenceModels -IlnInclude -I. -IOpenFOAM/OpenFOAM-1.4/src/OpenFOAM/lnInclude -fPIC -pthread Make/linuxGcc4DPOpt/rhoSimpleFoam.o -LOpenFOAM/OpenFOAM-1.4/lib/linuxGcc4DPOpt \
-lfiniteVolume -lmeshTools -lbasicThermophysicalModels -lspecie -lcompressibleTurbulenceModels -lOpenFOAM -liberty -ldl -lm -o OpenFOAM/OpenFOAM-1.4/applications/bin/linuxGcc4DPOpt/rhoSimpleFoam
/usr/bin/ld: cannot find -liberty
collect2: ld returned 1 exit status
make[2]: *** [OpenFOAM/OpenFOAM-1.4/applications/bin/linuxGcc4DPOpt/rhoSimpleFoam] Error 1
make[2]: Leaving directory `OpenFOAM/OpenFOAM-1.4/applications/solvers/compressible/rhoSimpleFoam'
make[1]: *** [rhoSimpleFoam] Error 2
make[1]: Leaving directory `OpenFOAM/OpenFOAM-1.4/applications/solvers/compressible'
make: *** [compressible] Error 2
+ cd utilities
+ wmake all
make[1]: Entering directory `OpenFOAM/OpenFOAM-1.4/applications/utilities/mesh'
make[2]: Entering directory `OpenFOAM/OpenFOAM-1.4/applications/utilities/mesh/manipulation'
make[3]: Entering directory `OpenFOAM/OpenFOAM-1.4/applications/utilities/mesh/manipulation/moveDynamicMesh'
g++ -m32 -Dlinux -DDP -Wall -Wno-strict-aliasing -Wextra -Wno-unused-parameter -Wold-style-cast -O3 -DNoRepository -ftemplate-depth-40 -IOpenFOAM/OpenFOAM-1.4/src/dynamicFvMesh/lnInclude -IOpenFOAM/OpenFOAM-1.4/src/meshTools/lnInclude -IOpenFOAM/OpenFOAM-1.4/src/finiteVolume/lnInclude -IlnInclude -I. -IOpenFOAM/OpenFOAM-1.4/src/OpenFOAM/lnInclude -fPIC -pthread Make/linuxGcc4DPOpt/moveDynamicMesh.o -LOpenFOAM/OpenFOAM-1.4/lib/linuxGcc4DPOpt \
-ldynamicFvMesh -lmeshTools -ldynamicMesh -lOpenFOAM -liberty -ldl -lm -o OpenFOAM/OpenFOAM-1.4/applications/bin/linuxGcc4DPOpt/moveDynamicMesh
/usr/bin/ld: cannot find -liberty
collect2: ld returned 1 exit status
make[3]: *** [OpenFOAM/OpenFOAM-1.4/applications/bin/linuxGcc4DPOpt/moveDynamicMesh] Error 1
make[3]: Leaving directory `OpenFOAM/OpenFOAM-1.4/applications/utilities/mesh/manipulation/moveDynamicMesh'
make[2]: *** [moveDynamicMesh] Error 2
make[2]: Leaving directory `OpenFOAM/OpenFOAM-1.4/applications/utilities/mesh/manipulation'
make[1]: *** [manipulation] Error 2
make[1]: Leaving directory `OpenFOAM/OpenFOAM-1.4/applications/utilities/mesh'
make: *** [mesh] Error 2

What's the cause ? Please, Need help !

[alberto]

The problem is:

/usr/bin/ld: cannot find -liberty

The solution is here:

http://www.cfd-online.com/OpenFOAM_D...es/1/3063.html

Regards,
A.

[benru]

Thank you, will try right now

Regards
Ruben

[benru]

To test purity of using new error.C (from patch for MAC) file I have tried to recompile all files in /src. Before it, I start script /wmake/wcleanAll from OpenFOAM-1.4 to leave previous compiled obj files & libs. The end of this process is :

+ cd malloc
+ ./Allwmake
+ wmake libo fbsdmalloc
OpenFOAM/OpenFOAM-1.4/wmake/wmakeLnInclude: linking include files to /OpenFOAM/OpenFOAM-1.4/src/malloc/fbsdmalloc/lnInclude

Making dependency list for source file fbsdmalloc.c
could not open file libc_private.h for source file fbsdmalloc.c
could not open file spinlock.h for source file fbsdmalloc.c
SOURCE=fbsdmalloc.c ; gcc -m32 -Dlinux -DDP -Wall -O3 -IlnInclude -I. -IOpenFOAM/OpenFOAM-1.4/src/OpenFOAM/lnInclude -fPIC -c $SOURCE -o Make/linuxGcc4DPOpt/fbsdmalloc.o
ld -melf_i386 -r -o OpenFOAM/OpenFOAM-1.4/lib/linuxGcc4DPOpt/libfbsdmalloc.o Make/linuxGcc4DPOpt/fbsdmalloc.o
`OpenFOAM/OpenFOAM-1.4/lib/linuxGcc4DPOpt/libfbsdmalloc.o' is up to date.
+ '[' '!' -r OpenFOAM/OpenFOAM-1.4/src/mico-2.3.12/platforms/linuxGcc4DPOpt/lib/libmico2.3.12 .a ']'
+ wmake libso foamUtil
OpenFOAM/OpenFOAM-1.4/wmake/wmakeLnInclude: linking include files to OpenFOAM/OpenFOAM-1.4/src/foamUtil/lnInclude

Making dependency list for source file libfoamUtil.C
SOURCE=libfoamUtil.C ; g++ -m32 -Dlinux -DDP -Wall -Wno-strict-aliasing -Wextra -Wno-unused-parameter -Wold-style-cast -O3 -DNoRepository -ftemplate-depth-40 -IlnInclude -I. -IOpenFOAM/OpenFOAM-1.4/src/OpenFOAM/lnInclude -fPIC -pthread -c $SOURCE -o Make/linuxGcc4DPOpt/libfoamUtil.o
`OpenFOAM/OpenFOAM-1.4/lib/linuxGcc4DPOpt/libfoamUtil.so' is up to date.

Is recompilation completed successfully, or absence of libc_private.h & spinlock.h critically influence to fbsdmalloc operation ? Where should these headers be and what packet they are correspond to ? Need Help !

[alberto]

It gives no errors so...

However, spinlock.h is in /usr/src/linux-2.6.xx/<platform> but also in /usr/include/linux.

I don't have libc_private.h on my openSUSE 10.2 64 bit.

Regards,
A.

[benru]

The same situation - libc_private.h is absent, spinlock.h in /usr/include/linux, but for why and wheather they need to fbsdmalloc ? Problem with libiberty.a i solved with copy one in OpenFoam-1.4/lib/linuxGcc4DPOpt (minimum action).

After recompiling /application i'll try to perform calcs.

Thank for help,
Regards
Ruben

[gschaider]

@liberty: In my experience that is not needed when using the Mac-error.C (the name Mac is a bit misleading (you can remove it from the wmake/rules): it supports Linux as the "main" architecture). Which is good because for me liberty introduced some nasty glibc-downwards-incompatibilities (but that was a very special problem between my workstation and our cluster: stuff compiled on one of them wouldn't run on the other)

@spinlock.h: I guess that's OK. The only problem seems to be that wmkdep tries to find headers that are never used during compiling because they're guarded by #ifdef

[benru]

What extension should libfbsdmalloc have : (.o) or (.so) ? Now, without spinlock.h & libc_private, it have .o extension. So, if spinlock.h & libc_private.h would be commented with // - libfbsdmalloc will have .so extension ?

Ruben

[benru]

Suggestion : in file /home/rmukhamadeev/OpenFOAM/OpenFOAM-1.4/src/malloc/fbsdmalloc/fbsdmalloc.c performs changes :
/* # include "libc_private.h" */
# include <linux/spinlock.h>

in spite of now:
# include "libc_private.h"
# include "spinlock.h"

Ruben

One more bug to correct is some versions of flex++ don't like "]]" in several .L files. Putting a space between the brackets (ie. changing them to "] ]") will fix it.

http://www.cfd-online.com/OpenFOAM_D...tml?1181838496

[benru]

2 Conn - Thank you for solution, it works !
Regards
Ruben