|
[Sponsors] |
Change in triangle::intersection breaks stitchMesh in 1.5 and 1.6 |
![]() |
|
LinkBack | Thread Tools | Search this Thread | Display Modes |
![]() |
![]() |
#1 |
Assistant Moderator
Bernhard Gschaider
Join Date: Mar 2009
Posts: 4,225
Rep Power: 52 ![]() ![]() |
This problem seems to have been introduced between 1.4.1 and 1.5: in earlier versions of OF even when the triangle was not hit the pointHit returned by triangle::intersection got some value. In 1.5 and 1.6 vector::zero is returned. Nevertheless this point value is then used in triangle::ray to calculate the distance to this point. I guess usually this distance is not used, but in slidingInterface:
![]() After applying the attached patches to 1.5.x and 1.6 and recompiling stitchMesh happily stitched meshes on which previously it failed. I don't know whether these patches affect other utilities as well If you want a mesh to verify the bug/fix, I can provide you with one Bernhard |
|
![]() |
![]() |
![]() |
![]() |
#2 |
Senior Member
Mattijs Janssens
Join Date: Mar 2009
Posts: 1,419
Rep Power: 27 ![]() |
Thanks. I would like to leave the fast intersection() routine intact since it is used all over so want to recalculate the intersection with plane inside the ray() routine. Can you try attached triangleI.H and/or post the testcase?
|
|
![]() |
![]() |
![]() |
![]() |
#3 |
Senior Member
Mattijs Janssens
Join Date: Mar 2009
Posts: 1,419
Rep Power: 27 ![]() |
Missing attachment.
|
|
![]() |
![]() |
![]() |
![]() |
#4 |
Assistant Moderator
Bernhard Gschaider
Join Date: Mar 2009
Posts: 4,225
Rep Power: 52 ![]() ![]() |
Yep. That fixes it. I'll mail you about the testcase
|
|
![]() |
![]() |
![]() |
![]() |
#5 |
Senior Member
Mattijs Janssens
Join Date: Mar 2009
Posts: 1,419
Rep Power: 27 ![]() |
I've pushed the fix to 1.6.x and 1.5.x.
|
|
![]() |
![]() |
![]() |
![]() |
#6 | |
New Member
X.G. Li
Join Date: Nov 2009
Location: Bremen, Germany
Posts: 19
Rep Power: 17 ![]() |
Quote:
Bernhard,,may you send me your recompiled stitchMesh.C,because i really donīt know where this patch should be put in the cold file.. Thank you very much! My e-mail is xgli@iwt.uni-bremen.de |
||
![]() |
![]() |
![]() |
![]() |
#7 | |
Assistant Moderator
Bernhard Gschaider
Join Date: Mar 2009
Posts: 4,225
Rep Power: 52 ![]() ![]() |
Quote:
The relevant patches should be in 1.5.x and 1.6.x so if you got one of those, everything's OK Bernhard |
||
![]() |
![]() |
![]() |
![]() |
#8 | |
New Member
X.G. Li
Join Date: Nov 2009
Location: Bremen, Germany
Posts: 19
Rep Power: 17 ![]() |
![]() Quote:
|
||
![]() |
![]() |
![]() |
Thread Tools | Search this Thread |
Display Modes | |
|
|
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
CFX4.3 -build analysis form | Chie Min | CFX | 5 | July 12, 2001 23:19 |