label/scalar mixup in hierarchGeomDecomp.C
The bug is in src/decompositionMethods/decompositionMethods/hierarchGeomDecomp/hierarchGeomDecomp.C:
Code:
279 label weightedSize = returnReduce Code:
--- a/src/decompositionMethods/decompositionMethods/hierarchGeomDecomp/hierarchGeomDecomp.C |
Similarly for src/dynamicMesh/slidingInterface/slidingInterface.C:
Code:
--- a/src/dynamicMesh/slidingInterface/slidingInterface.C |
Thanks, I've pushed them into 1.7.x. By the way, how did you find these - gcc4.4 does not seem to warn about them.
We've finally got a proper bug reporting system :-) Please report any future bugs on http://www.openfoam.com/bugs. |
gcc4.1.2 does ;-) probably 4.4 would too with proper warning flags.
Kudos for the Mantis bug tracker! At last, I'd say :-) |
Hi Michael,
It would be very nice if you might explain a little bit about this function call returnReduce(. ,. ). I have find its definition "PstreamReduceOps.H" but could not understand what this will return. Your short description about this function would help me a lot. Thanks in Advance |
returnReduce() is a reduction operation (e.g. sum, min, max, cumulative sum, product, cumulative product, etc) across all processors for parallel runs. The first argument is the value on the local processor and the second argument is the binary operator performing the reduction operation between two arguments. This can be a functor or a function pointer.
The problem in the reported issue is that the functor objects where created for label type (i.e. int), while the value argument was a scalar (i.e. double or float). HTH Michael |
Hi Michael,
Thanks for the prompt reply. It clarifies the things I am looking at. |
All times are GMT -4. The time now is 07:50. |