CFD Online Discussion Forums

CFD Online Discussion Forums (https://www.cfd-online.com/Forums/)
-   OpenFOAM Community Contributions (https://www.cfd-online.com/Forums/openfoam-community-contributions/)
-   -   [isoAdvector] Important bugfix for isoAdvector (https://www.cfd-online.com/Forums/openfoam-community-contributions/199917-important-bugfix-isoadvector.html)

roenby March 19, 2018 09:23

Important bugfix for isoAdvector
 
Lately some users have reported spurious bubbles being created in the water column when using isoAdvector. The bug has now been tracked down and fixed:

Cause:
In June 2017, OpenFOAM Foundation committed a change in the functionality of the basic functions, pos() and neg(). This change caused the change in isoAdvector behaviour when using a snapTol larger than zero.

Fix:
The old functionality of pos and neg was put into the new functions pos0 and neg0, so the fix was simply to replace all occurrences of pos/neg with pos0/neg0 in the isoAdvector code to get back the original intended behaviour.

As of 19 March 2018, this fix has been applied to isoAdvector on github.com/isoAdvector and on openfoam.com/Development.


Cheers,
Johan


All times are GMT -4. The time now is 17:59.