|
[Sponsors] |
[openComfort] New openComfort library published |
|
LinkBack | Thread Tools | Search this Thread | Display Modes |
August 25, 2017, 04:29 |
New openComfort library published
|
#1 |
Super Moderator
Tobias Holzmann
Join Date: Oct 2010
Location: Tussenhausen
Posts: 2,708
Blog Entries: 6
Rep Power: 51 |
Hi all,
I am happy to announce that I developed a new openComfort library + application which can be used to analyze thermal comfort behavior based on EN ISO 7730. The code can be found on my website including the openComfort library, the comfortFoam application and two tutorials that show how to use it. Based on the fact that I am not a civil engineer or at least working in that field of application, I cannot tell you if the values that are calculated are reliable. Feedback is welcomed. In addition, I will not support / update or change the old comfortFoam which was developed by Thomas Tian. I keep it on my bitbucket but it contains some mistakes and based on the new library (which allows easier maintenance and extension) it is depreciated. The library calculates:
The library and application can be found on Holzmann CFD | Software Development
__________________
Keep foaming, Tobias Holzmann |
|
September 27, 2017, 06:48 |
|
#2 |
Member
Pekka Pasanen
Join Date: Feb 2012
Location: Finland
Posts: 87
Rep Power: 14 |
This is great! I've been thinking about doing something like this for a long time now but haven't had the time. It would be great to have something like this included as a functionObject to OpenFOAM code base. I will definitely test this
Also, I think it should be pretty easy to add other thermal comfort models to the library? |
|
September 27, 2017, 07:43 |
|
#3 |
Super Moderator
Tobias Holzmann
Join Date: Oct 2010
Location: Tussenhausen
Posts: 2,708
Blog Entries: 6
Rep Power: 51 |
Hi,
I was forced by Thomas Tian to do it - he never gave up asking me: Tobi when do you check the comfortFoam application. However, I did a complete new development exactly based on easy maintenance and flexibility. Due to the fact that it is a library now, you can easily add it to the functions and using it in the postProcess utility. I was mentioning it to the Foundation (https://bugs.openfoam.org/view.php?id=2678) but it should be extended further. Right now I only added the usage to incompressible flows. If you extend it, feel free to make a push request.
__________________
Keep foaming, Tobias Holzmann |
|
October 12, 2017, 05:36 |
Error with Comfortfoam Solver while running in K-Epsilon
|
#4 | |
New Member
Shadab Mohammed
Join Date: Aug 2017
Posts: 14
Rep Power: 11 |
Hi Tobi,
I have downloaded the comfortFoam solver, from your website and compiled it successfully. As I am interested in your solver and want to make it for compressible flow cases, presently i am checking your solver for incompressible case with K-Epsilon model. Your solver running fine on simple geometry case in laminar flow, when i want to run this solver by using RAS K-epsilon model. The bouyantBoussinesq solver completed its 600 iteration, but upon using comfortFoam solver, in its first iteration after Solution of AOA this error has generated. Quote:
Please help me out of this problem. I have attached my log files in simple geometry zip file. Thanks & Regards Shadab |
||
October 13, 2017, 08:37 |
Implementation of Comprssible part for the calculation of AOA
|
#5 |
New Member
Shadab Mohammed
Join Date: Aug 2017
Posts: 14
Rep Power: 11 |
Hello Foamers,
I have try to implement the compressible part in openComfort.C file. I am not very good in implementing of solver, I understand the code and try to implement the compressible part of it. When I compiled the solver it is giving many errors, I am understanding the errors but I am not able to find the solution. The error report is given below. Code:
mechartes@MRDC-001:~/Thermal_Comfort/Solver_Development/opencomfort/src/openComfort$ wmake wmakeLnInclude: linking include files to ./lnInclude Making dependency list for source file openComfort.C g++ -std=c++11 -m64 -Dlinux64 -DWM_ARCH_OPTION=64 -DWM_DP -DWM_LABEL_SIZE=32 -Wall -Wextra -Wold-style-cast -Wnon-virtual-dtor -Wno-unused-parameter -Wno-invalid-offsetof -O0 -fdefault-inline -ggdb3 -DFULLDEBUG -DNoRepository -ftemplate-depth-100 -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/TurbulenceModels/turbulenceModels/lnInclude -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/TurbulenceModels/incompressible/lnInclude -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/transportModels -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/transportModels/incompressible/singlePhaseTransportModel -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/transportModels/compressible/lnInclude -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/thermophysicalModels/basic/lnInclude -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/thermophysicalModels/radiation/lnInclude -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/TurbulenceModels/turbulenceModels/lnInclude -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/TurbulenceModels/compressible/lnInclude -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/finiteVolume/lnInclude -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/meshTools/lnInclude -IlnInclude -I. -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/OpenFOAM/lnInclude -I/home/mechartes/OpenFOAM/OpenFOAM-5.0/src/OSspecific/POSIX/lnInclude -fPIC -c openComfort.C -o Make/linux64GccDPInt32Debug/openComfort.o openComfort.C: In member function ‘void Foam::openComfort::AoA() const’: openComfort.C:231:13: error: ‘rho’ was not declared in this scope rho, ^~~ openComfort.C:232:13: error: ‘U’ was not declared in this scope U, ^ openComfort.C:233:13: error: ‘phi’ was not declared in this scope phi, ^~~ openComfort.C:234:13: error: ‘thermo’ was not declared in this scope thermo ^~~~~~ In file included from openComfort.C:238:0: /home/mechartes/OpenFOAM/OpenFOAM-5.0/src/finiteVolume/lnInclude/compressibleCreatePhi.H:41:9: error: ‘runTime’ was not declared in this scope runTime.timeName(), ^~~~~~~ /home/mechartes/OpenFOAM/OpenFOAM-5.0/src/finiteVolume/lnInclude/compressibleCreatePhi.H:42:9: error: ‘mesh’ was not declared in this scope mesh, ^~~~ /home/mechartes/OpenFOAM/OpenFOAM-5.0/wmake/rules/General/transform:25: recipe for target 'Make/linux64GccDPInt32Debug/openComfort.o' failed make: *** [Make/linux64GccDPInt32Debug/openComfort.o] Error 1 Thanks and Regards Shadab |
|
October 13, 2017, 08:46 |
|
#6 |
Super Moderator
Tobias Holzmann
Join Date: Oct 2010
Location: Tussenhausen
Posts: 2,708
Blog Entries: 6
Rep Power: 51 |
Hi,
if you build it, keep a clean programming and make a pull request. I can add the extension and do not provide it myself (lack of time). However to your problem. As it is written, e.g. rho is not defined: Code:
solveAoA(rho, muEff, phi); To your comment with the references (turb->muEff()); I don't know why I did not use a reference here but there was a reason for doing that. Cannot remember. Is there a reason why you comment the incompressible code pieces?
__________________
Keep foaming, Tobias Holzmann Last edited by Tobi; October 13, 2017 at 14:09. |
|
October 14, 2017, 07:56 |
Compressible AoA Implemented
|
#7 |
Super Moderator
Tobias Holzmann
Join Date: Oct 2010
Location: Tussenhausen
Posts: 2,708
Blog Entries: 6
Rep Power: 51 |
Hi Shadab Mohammed and dear community,
based on the try of Shadab to implement the compressible AoA calculation into the openComfort library, I took the time to implement the it today. In addition, I can tell you why we could not use the references in the viscosity statement. The nuEff() function will return a tmp<> object. I tried to wrap it to get the reference but it was not working. Right now the only way is the copy but I do not know if it is a real copy in that case. I have to check out the tmp class for that to be sure what is going on here. Please let me know if the calculation works.
__________________
Keep foaming, Tobias Holzmann Last edited by Tobi; October 14, 2017 at 07:57. Reason: Title |
|
October 15, 2017, 05:56 |
|
#8 |
Super Moderator
Tobias Holzmann
Join Date: Oct 2010
Location: Tussenhausen
Posts: 2,708
Blog Entries: 6
Rep Power: 51 |
Problem with the copy of the nuEff() and muEff() field is resolved by commit f1a1a2de3b3f1828d3f4eb108d6509992ff9a8f6
__________________
Keep foaming, Tobias Holzmann |
|
October 16, 2017, 02:32 |
|
#9 |
Senior Member
Join Date: Aug 2013
Posts: 407
Rep Power: 15 |
Hi Tobi,
Noticed that you are missing a } in line 203 of openComfort.C in the latest commit. Cheers, Antimony |
|
October 16, 2017, 03:00 |
|
#10 |
Super Moderator
Tobias Holzmann
Join Date: Oct 2010
Location: Tussenhausen
Posts: 2,708
Blog Entries: 6
Rep Power: 51 |
Good morning Antimony,
thank you for the report. Interesting because I checked the compilation yesterday. However, maybe my fingers in vim were too fast and I did some deletion. The problem is resolved in commit 21922e6f4476c0c5697c4949245c6835ab77ef27
__________________
Keep foaming, Tobias Holzmann |
|
February 1, 2019, 07:01 |
|
#11 |
Member
Ahmad Habib
Join Date: Nov 2014
Location: Aleppo, Syria
Posts: 53
Rep Power: 11 |
Hello Tobias
Great library, but if it is possible I need some documentation about the theoretical and mathematical equations about the calculation of PMV, Tcl, and AoA. Thanks in advance. Regards. |
|
April 7, 2019, 12:57 |
|
#12 |
New Member
Pu Gong
Join Date: Jul 2018
Location: London
Posts: 22
Rep Power: 7 |
Hi Tobi,
The opencomfort code is no longer in your bitbuket, could you give another link available? Cheers |
|
October 16, 2019, 13:44 |
|
#14 |
Super Moderator
Tobias Holzmann
Join Date: Oct 2010
Location: Tussenhausen
Posts: 2,708
Blog Entries: 6
Rep Power: 51 |
Hi everybody,
I rebuild the code as objectFunction which will be released soon in the DEV line of the Foundation version. Enjoy.
__________________
Keep foaming, Tobias Holzmann |
|
Tags |
opencomfort |
|
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
[Other] Multi species mass transport library [update] | novyno | OpenFOAM Community Contributions | 111 | November 9, 2021 23:37 |
ERROR: unable to find library | HJH | CFX | 6 | February 26, 2019 06:52 |
Forcing a solver to use your custom library. | cdunn6754 | OpenFOAM Programming & Development | 0 | March 30, 2017 16:05 |
Compiled library vs. inInclude Files, DSMC solver crashes after run | GPesch | OpenFOAM Programming & Development | 8 | April 18, 2013 07:17 |
OpenFOAM141dev linking error on IBM AIX 52 | matthias | OpenFOAM Installation | 24 | April 28, 2008 15:49 |