CFD Online Logo CFD Online URL
www.cfd-online.com
[Sponsors]
Home > Forums > Software User Forums > OpenFOAM > OpenFOAM Community Contributions

[openSmoke] libOpenSMOKE

Register Blogs Members List Search Today's Posts Mark Forums Read

Like Tree133Likes

Reply
 
LinkBack Thread Tools Search this Thread Display Modes
Old   May 1, 2020, 10:37
Default
  #541
Super Moderator
 
Tobi's Avatar
 
Tobias Holzmann
Join Date: Oct 2010
Location: Augsburg
Posts: 2,390
Blog Entries: 6
Rep Power: 42
Tobi has a spectacular aura aboutTobi has a spectacular aura aboutTobi has a spectacular aura about
Send a message via ICQ to Tobi Send a message via Skype™ to Tobi
Dear all,


I just want to inform you that I moved the repository to github and rebuild the code for OpenFOAM 7.x.
https://github.com/shor-ty/CRECKFlameletModel



Tobi
__________________
Keep foaming,
Tobias Holzmann
Tobi is offline   Reply With Quote

Old   May 14, 2020, 12:39
Default
  #542
New Member
 
Join Date: Nov 2019
Posts: 3
Rep Power: 2
azu037 is on a distinguished road
Hello Tobi,

Make/files are missing for all folders that are to be compiled. I reused the ones from your OpenFOAM 4.x version with some minor modifications and it seems to be working fine!
Thank you very much for still working on this. It is much appreciated.

Greetings,
azu037


Edit: You mention the ability to use the PIMPLE-algorithm for transient calculations in your description but I couldn't get it to work.The solver complains about missing the SIMPLE settings in fvSolution ...
azu037 is offline   Reply With Quote

Old   May 14, 2020, 12:42
Default
  #543
Super Moderator
 
Tobi's Avatar
 
Tobias Holzmann
Join Date: Oct 2010
Location: Augsburg
Posts: 2,390
Blog Entries: 6
Rep Power: 42
Tobi has a spectacular aura aboutTobi has a spectacular aura aboutTobi has a spectacular aura about
Send a message via ICQ to Tobi Send a message via Skype™ to Tobi
Ah I see, I will change it. If you do have it for any version please make a pull request.

Thanks.

PS: I am not working on the code anymore, I just keep it up-to-date for compatibility reasons.
azu037 likes this.
__________________
Keep foaming,
Tobias Holzmann
Tobi is offline   Reply With Quote

Old   May 15, 2020, 06:18
Default
  #544
New Member
 
Join Date: Nov 2019
Posts: 3
Rep Power: 2
azu037 is on a distinguished road
It's really more than you can ask for, keeping it up to date!


I have a general question to all the people in the thread. I tried to get the transient solver to work with the SANDIA flame but I always encounter a sigFPE error. I tried different settings for the solvers, checked the BCs and schemes but to no avail. Sadly there is no transient tutorial case for the 2.3.x version to get a working example from but I tried settings from Hagen Müller's and Alberto Cuoci's transient tutorial case.


I'd be very grateful for some input or - even better - a working case to learn from.


Edit: I don't have a GitHub-Account but the changes from the 4.x version are minuscule. You just have to remove the folders src or flamelet in the paths of the files referenced in the Make/files
azu037 is offline   Reply With Quote

Old   May 15, 2020, 08:14
Default
  #545
Super Moderator
 
Tobi's Avatar
 
Tobias Holzmann
Join Date: Oct 2010
Location: Augsburg
Posts: 2,390
Blog Entries: 6
Rep Power: 42
Tobi has a spectacular aura aboutTobi has a spectacular aura aboutTobi has a spectacular aura about
Send a message via ICQ to Tobi Send a message via Skype™ to Tobi
Hi, the setup should be the same. The only thing that will change is the solver. I once had the transient solver added to the repository. Hmm ... maybe I should do it again.

I just saw that Hagen Müller made another derivation for the transient solver. The implementation to FOAM was also a bit different. He had hard coded something to the turbulence models which I did not like as it will destroy the original. However, if I remember correctly, he took some compressibility into account. So the solver derivation regarding the pressure equation was a bit different.

Tobi
__________________
Keep foaming,
Tobias Holzmann
Tobi is offline   Reply With Quote

Old   May 19, 2020, 05:11
Default
  #546
New Member
 
qian yao
Join Date: May 2020
Posts: 6
Rep Power: 2
mikeYao is on a distinguished road
hi tobi
i try to compile following the instructions posted on github(https://github.com/shor-ty/CRECKFlam...e/OpenFOAM-4.x). but i get some errors " no matching function for call to..." what's wrong
i also get some "unused variable" warnings

flameletSimpleFoam.C:62:31: error: no matching function for call to ‘Foam::simpleControl::loop(Foam::Time&)’
while (simple.loop(runTime))
^
In file included from flameletSimpleFoam.C:36:0:
/opt/openfoam4/src/finiteVolume/lnInclude/simpleControl.H:106:26: note: candidate: virtual bool Foam::simpleControl::loop()
virtual bool loop();
^
/opt/openfoam4/src/finiteVolume/lnInclude/simpleControl.H:106:26: note: candidate expects 0 arguments, 1 provided
In file included from flameletSimpleFoam.C:68:0:
ZEqn.H:10:15: error: no matching function for call to ‘Foam::fvMatrix<double>::solve(const char [2])’
ZEqn.solve("Z");
^
In file included from /opt/openfoam4/src/finiteVolume/lnInclude/fvMatrix.C:2396:0,
from /opt/openfoam4/src/finiteVolume/lnInclude/fvMatrix.H:1058,
from /opt/openfoam4/src/finiteVolume/lnInclude/ddtScheme.C:29,
from /opt/openfoam4/src/finiteVolume/lnInclude/ddtScheme.H:337,
from /opt/openfoam4/src/finiteVolume/lnInclude/fvcDdt.C:28,
from /opt/openfoam4/src/finiteVolume/lnInclude/fvcDdt.H:199,
from /opt/openfoam4/src/finiteVolume/lnInclude/fvc.H:44,
from /opt/openfoam4/src/finiteVolume/lnInclude/fvCFD.H:8,
from flameletSimpleFoam.C:33:
/opt/openfoam4/src/finiteVolume/lnInclude/fvMatrixSolve.C:56:31: note: candidate: Foam::SolverPerformance<Type> Foam::fvMatrix<Type>::solve(const Foam::dictionary&) [with Type = double]
Foam::SolverPerformance<Type> Foam::fvMatrix<Type>::solve
^
/opt/openfoam4/src/finiteVolume/lnInclude/fvMatrixSolve.C:56:31: note: no known conversion for argument 1 from ‘const char [2]’ to ‘const Foam::dictionary&’
/opt/openfoam4/src/finiteVolume/lnInclude/fvMatrixSolve.C:313:31: note: candidate: Foam::SolverPerformance<Type> Foam::fvMatrix<Type>::solve() [with Type = double]
Foam::SolverPerformance<Type> Foam::fvMatrix<Type>::solve()
^
/opt/openfoam4/src/finiteVolume/lnInclude/fvMatrixSolve.C:313:31: note: candidate expects 0 arguments, 1 provided
In file included from flameletSimpleFoam.C:68:0:
ZEqn.H:27:25: error: no matching function for call to ‘Foam::fvMatrix<double>::solve(const char [5])’
ZvarEqn.solve("Zvar");
mikeYao is offline   Reply With Quote

Old   May 19, 2020, 08:12
Default
  #547
Super Moderator
 
Tobi's Avatar
 
Tobias Holzmann
Join Date: Oct 2010
Location: Augsburg
Posts: 2,390
Blog Entries: 6
Rep Power: 42
Tobi has a spectacular aura aboutTobi has a spectacular aura aboutTobi has a spectacular aura about
Send a message via ICQ to Tobi Send a message via Skype™ to Tobi
Hi,

what I can tell you is the following:
  1. A warning is just a warning, its fine
  2. Based on your error, I don't believe that you did exactly what is given in the readme

Code:
flameletSimpleFoam.C:62:31: error: no matching function for call to ‘Foam::simpleControl::loop(Foam::Time&)’
while (simple.loop(runTime))
^
If you go to the source code of the OpenFOAM-4.x version (https://github.com/shor-ty/CRECKFlam...etSimpleFoam.C), you will see that the code in line 62 differs to the one in your error message. I guess you are still on the master branch rather than on the OpenFOAM-4.x branch.

Code:
git branch
This shows you on which branch you are looking at the moment. I would expect that it is not OpenFOAM-4.x. So please switch to the correct branch:

Code:
git checkout OpenFOAM-4.x
Tobi
__________________
Keep foaming,
Tobias Holzmann
Tobi is offline   Reply With Quote

Old   May 19, 2020, 21:57
Default
  #548
New Member
 
qian yao
Join Date: May 2020
Posts: 6
Rep Power: 2
mikeYao is on a distinguished road
hi tobi
thanks for your help.
ps: the git link in compile instruction for OpenFOAM 4.x is out of date
mikeYao is offline   Reply With Quote

Old   May 26, 2020, 04:02
Default
  #549
New Member
 
qian yao
Join Date: May 2020
Posts: 6
Rep Power: 2
mikeYao is on a distinguished road
hi tobi,
i downloaded kinetics from http://creckmodeling.chem.polimi.it/...1-c1-c3-ht-nox
and i try to interpret it into idealgas.bin and reactions.bin, using command:
./OpenSMOKE_CHEMKINInterpreter.sh --kinetics "kinetic(2003)/CRECK_2003_C1_C3_HT_NOX.cki" --thermo "kinetic(2003)/CRECK_2003_C1_C3_HT_NOX.ckt" --transport "kinetic(2003)/CRECK_2003_C1_C3_HT_NOX.trc" --output "OutputFolder"
but i got this message:
** Reading thermodynamic database...
Class: OpenSMOKE_CHEMKINInterpreter_ThermoData
Object:
Error: Expected: THERMO - Found:
Press a key to continue...
what does it mean?
regards,
mike
mikeYao is offline   Reply With Quote

Old   May 26, 2020, 12:21
Default
  #550
Super Moderator
 
Tobi's Avatar
 
Tobias Holzmann
Join Date: Oct 2010
Location: Augsburg
Posts: 2,390
Blog Entries: 6
Rep Power: 42
Tobi has a spectacular aura aboutTobi has a spectacular aura aboutTobi has a spectacular aura about
Send a message via ICQ to Tobi Send a message via Skype™ to Tobi
As it is written. The program expects the word Thermo rather than -
__________________
Keep foaming,
Tobias Holzmann
Tobi is offline   Reply With Quote

Old   May 26, 2020, 21:24
Default
  #551
New Member
 
qian yao
Join Date: May 2020
Posts: 6
Rep Power: 2
mikeYao is on a distinguished road
hi tobi,
i don't understand where this - exists. i did not find it in .ckt thermo file.
and OpenSMOKE_CHEMKINInterpreter.sh is not written in human language. is there any other file need to look in?
regards,
mike
Attached Files
File Type: txt CRECK_2003_C1_C3_HT_NOX.txt (51.4 KB, 2 views)
mikeYao is offline   Reply With Quote

Old   May 27, 2020, 03:58
Default
  #552
Super Moderator
 
Tobi's Avatar
 
Tobias Holzmann
Join Date: Oct 2010
Location: Augsburg
Posts: 2,390
Blog Entries: 6
Rep Power: 42
Tobi has a spectacular aura aboutTobi has a spectacular aura aboutTobi has a spectacular aura about
Send a message via ICQ to Tobi Send a message via Skype™ to Tobi
The version you are using cannot handle "comments or whitespaces" and is restricted to the original format:
Code:
! This thermodynamic database was obtained by fitting the thermodynamic properties
! extracted from the following file: TOT2003.THERM
! The thermodynamic properties are fitted in order to preserve not only the 
! continuity of each function at the intermediate temperature, but also the  continuity
! of the derivatives, from the 1st to the 3rd order
! The intermediate temperatures are chosen in order to minimize the fitting error.
! Last update: 3/24/2020

THERMO ALL
270.   1000.   3500. 
AR                      AR  1               G    200.00   3500.00  820.00      1
 2.50013931e+00-3.98290200e-07 3.45886082e-10-1.18293971e-13 1.38553174e-17    2
-7.45407891e+02 4.37897362e+00 2.49974489e+00 1.52569132e-06-3.17359231e-09    3
 2.74307057e-12-8.58511922e-16-7.45343207e+02 4.38079817e+00                   4
N2                      N   2               G    200.00   3500.00 1050.00      1

Has to be changed to:
Code:
THERMO ALL
270.   1000.   3500. 
AR                      AR  1               G    200.00   3500.00  820.00      1
 2.50013931e+00-3.98290200e-07 3.45886082e-10-1.18293971

The first word in the file has to be THERMO without whitespaces or any other empty lines.
__________________
Keep foaming,
Tobias Holzmann
Tobi is offline   Reply With Quote

Old   May 27, 2020, 09:04
Default
  #553
New Member
 
qian yao
Join Date: May 2020
Posts: 6
Rep Power: 2
mikeYao is on a distinguished road
hi tobi,
does it mean that i can't use OpenSMOKE_CHEMKINInterpreter.sh to process .cki or .ckt or .trc file?
i got this message:
** Reading thermodynamic database...
terminate called after throwing an instance of 'std:ut_of_range'
what(): basic_string::substr
Aborted (core dumped)
regards,
mike
mikeYao is offline   Reply With Quote

Old   May 27, 2020, 09:25
Default
  #554
Super Moderator
 
Tobi's Avatar
 
Tobias Holzmann
Join Date: Oct 2010
Location: Augsburg
Posts: 2,390
Blog Entries: 6
Rep Power: 42
Tobi has a spectacular aura aboutTobi has a spectacular aura aboutTobi has a spectacular aura about
Send a message via ICQ to Tobi Send a message via Skype™ to Tobi
As you might already realized, the interpreter as well as the kinetic applications are binaries and therefore, we cannot analyze the code. If you do have problems regarding the application you should ask the people from CRECK Modeling group. Personal, I never had the feeling they want to support people. My messages was only replied two/three times, so no chance. I signed for the openSMOKE application in order to see what they did new but I never got access. Thus, good luck.


Tobi
__________________
Keep foaming,
Tobias Holzmann
Tobi is offline   Reply With Quote

Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
[openSmoke] flameletSmoke + new ODESolver (by Alberto Cuoci) Tobi OpenFOAM Community Contributions 1 November 21, 2017 18:24
Numerical treatment of the source term in combustion equations Tobi Main CFD Forum 36 March 20, 2017 08:58
Unsteady solver with Flamelet Model (libOpenSMOKE) francesco_capuano OpenFOAM Running, Solving & CFD 11 November 26, 2013 04:50
LibOpenSmoke, getting the species in ParaFoam Christoph_84 OpenFOAM 1 May 31, 2012 14:42


All times are GMT -4. The time now is 11:51.