CFD Online Logo CFD Online URL
www.cfd-online.com
[Sponsors]
Home > Forums > Software User Forums > OpenFOAM > OpenFOAM Programming & Development

dnsFoam question

Register Blogs Community New Posts Updated Threads Search

Reply
 
LinkBack Thread Tools Search this Thread Display Modes
Old   June 1, 2015, 16:10
Default dnsFoam question
  #1
Senior Member
 
Alexey Matveichev
Join Date: Aug 2011
Location: Nancy, France
Posts: 1,930
Rep Power: 38
alexeym has a spectacular aura aboutalexeym has a spectacular aura about
Send a message via Skype™ to alexeym
Dear all,

I am a little bit puzzled by dnsFoam (and it started with unused variables warnings). dnsFoam includes readPISOcontrols.H file and has comment

Code:
// --- PISO loop
yet the loop itself does not use any PISO controls:

Code:
for (int corr=1; corr<=1; corr++)
{
    ...
}
(in pisoFoam loop exit criterion is corr<nCorr)

The implementation of dnsFoam does not seem to change from 2.0.x version and solver compiles without #include "readPISOControls.H" line (and in this case there are no warnings about unused variables).

So, is it intentionally left as a reminder, that one can use PISO in dnsFoam, or just another run-away code?
alexeym is offline   Reply With Quote

Old   June 2, 2015, 05:18
Default
  #2
Senior Member
 
Alexey Matveichev
Join Date: Aug 2011
Location: Nancy, France
Posts: 1,930
Rep Power: 38
alexeym has a spectacular aura aboutalexeym has a spectacular aura about
Send a message via Skype™ to alexeym
Will reply myself just in case. According to https://github.com/OpenFOAM/OpenFOAM...802f1fad32d1d6, loop should be corrected rather than include removed.
alexeym is offline   Reply With Quote

Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
dnsFoam in parallel - Has anyone tried this? chrisb2244 OpenFOAM Programming & Development 5 May 29, 2022 15:00
small question about the functionalities of topological changes in OpenFoam ngj OpenFOAM Running, Solving & CFD 2 February 28, 2013 10:02
Question Re Engineering Data Source imnull ANSYS 0 March 5, 2012 13:51
internal field question - PitzDaily Case atareen64 OpenFOAM Running, Solving & CFD 2 January 26, 2011 15:26
Poisson Solver question Suresh Main CFD Forum 3 August 12, 2005 04:37


All times are GMT -4. The time now is 10:24.