[Lisandro Maders]

Hello,

I programmed a code that is compiling fine in OpenFOAM 2.4.0. However, I tried to compile it in blue-cfd , which is based on OpenFOAM 4.x and I got an error, which is described as follows. I compiled the native OpenFOAM 4.x in my Ubuntu in order to test and I got the same error, so the error is not related to blue-cfd or Windows.

The line which the error occurs is in bold red. Here is only a piece of the code:

Foam::tmp<Foam::volVectorField> Foam::readSourceData::assignSourceValues
(
    const fvMesh& mesh
)
{
    tmp<volVectorField> tsource
    (
        new volVectorField
        (
            IOobject
            (
                "source",
                mesh.time().timeName(),
                mesh,
                IOobject::NO_READ,
                IOobject::NO_WRITE
            ),
            mesh,
            dimensionedVector("zero", dimensionSet(1,-2,-2,0,0,0,0),Foam::vector(0,0,0))
        )
    );
    
    volVectorField& source = tsource();
    
    forAll(source,celli)
    {

....
....    Lot of stuff    .....
....

        source[celli] = Foam::vector(sourceData_[a][4],sourceData_[a][5],sourceData_[a][6]);
    }

...
....
......

The error which is shown in the terminal is:

readSourceData/readSourceData.C: In member function ‘Foam::tmp<Foam::GeometricField<Foam::Vector<double>, Foam::fvPatchField, Foam::volMesh> > Foam::readSourceData::assignSourceValues(const Foam::fvMesh&)’:
readSourceData/readSourceData.C:180:38: error: invalid initialization of reference of type ‘Foam::volVectorField& {aka Foam::GeometricField<Foam::Vector<double>, Foam::fvPatchField, Foam::volMesh>&}’ from expression of type ‘const Foam::GeometricField<Foam::Vector<double>, Foam::fvPatchField, Foam::volMesh>’
     volVectorField& source = tsource();
                                      ^
make: *** [Make/linux64GccDPInt64Opt/./readSourceData/readSourceData.o] Error 1

I thought that the

 tsource();

was returning a const reference and the

volVectorField& source

was not constant, but apparently it is not this.

Any one that have any idea I would appreciate this.

[Zeppo]

volVectorField& source = tsource();

->

volVectorField& source = tsource.ref();

[Lisandro Maders]

I am struggling to download OF4.x in another machine.. As soon as I do this I will check your suggestion and see if it works.

But anyway, my C++ is not the best in the world, but as far as I have read, and I quote now, "for tmp objects, non-const access uses a ref() function rather than the () dereferencing operator.".

This was changed from OpenFOAM 4.0 version on, that's why it was compiling fine in OpenFOAM 2.4 version and not in OF4.X versions..

It will probably work now.. I let you know as soon as I verify it.

Edit: Yes, it worked!!

Thanks a lot!

Lisandro Maders