Difference in computation of "e" and "wallHeatFlux" between v6 and v6-patched

deepbandivadekar · November 26, 2019, 11:23

Hello,

I noticed that the heat flux on the wall differed when I ran a case in v6 (or v5) and the patched v6. On further investigation I noticed that the residuals for "e" in the log were different from step 1. So it looks like when v6 was patched, somewhere, something was changed that affected energy computations. I wanted to know exactly what has changed in these two versions. I need to know exactly which version is correct and why.

I'm trying to create a simpler case to show you a comparison. However, I'm looking for any direction wrt how to approach finding cause for such differences.

1. I have looked at the changelog for each new patch for v6 and found nothing that could be directly related to this.
2. I tried to compare the /src/ for both versions but it's a real pain because of irrelevant differences like added comments or changes from "small" to SMALL" etc. Is there a better way to approach this? Is it possible to narrow down the possible locations for this comparison?

Thanks

einstein_zee · November 26, 2019, 11:51

Hey there,

well, if you considered v6 with applied commits on github as "patched v6" then you may start to look for it on "commits" section for v6. For each commit also you may find a description as a reason for the change.

deepbandivadekar · November 26, 2019, 12:09

Quote:

Originally Posted by einstein_zee

Hey there,

well, if you considered v6 with applied commits on github as "patched v6" then you may start to look for it on "commits" section for v6. For each commit also you may find a description as a reason for the change.

Oh well! I was going to reply saying I have already been through them but just thought of revisiting, in case if I had missed something. And indeed I had.

They fixed this in one of the patches: https://bugs.openfoam.org/view.php?id=3025

So the v6 unpatched is wrong at least for rhoCentralFoam.

Okaydokes.

November 26, 2019, 11:23	Difference in computation of "e" and "wallHeatFlux" between v6 and v6-patched	#1
deepbandivadekar Senior Member Deep Join Date: Oct 2017 Posts: 180 Rep Power: 8	Hello, I noticed that the heat flux on the wall differed when I ran a case in v6 (or v5) and the patched v6. On further investigation I noticed that the residuals for "e" in the log were different from step 1. So it looks like when v6 was patched, somewhere, something was changed that affected energy computations. I wanted to know exactly what has changed in these two versions. I need to know exactly which version is correct and why. I'm trying to create a simpler case to show you a comparison. However, I'm looking for any direction wrt how to approach finding cause for such differences. 1. I have looked at the changelog for each new patch for v6 and found nothing that could be directly related to this. 2. I tried to compare the /src/ for both versions but it's a real pain because of irrelevant differences like added comments or changes from "small" to SMALL" etc. Is there a better way to approach this? Is it possible to narrow down the possible locations for this comparison? Thanks

November 26, 2019, 11:51		#2
einstein_zee Member Hosein Join Date: Nov 2011 Location: Germany Posts: 93 Rep Power: 14	Hey there, well, if you considered v6 with applied commits on github as "patched v6" then you may start to look for it on "commits" section for v6. For each commit also you may find a description as a reason for the change.