[palarcon]

Hello everybody

I'm trying to include PETSc into my OpenFOAM code in order to be able to perform some topology optimization developments (mainly becase there is a version of the MMA optimizer already coded with PETSc).

So far, I have been able to include petsc.hand the related directories/libraries in the "options" file and everything seems OK before compiling.

My problem is that OF and PETSc, both have the same "pow" function, so when I try to compile my code there is a call to an overloaded function and I don't really know how to solve it.

/home/pablo/PETSC/3.11.2/include/petscmath.h:400:38: error: call of overloaded ‘pow(PetscScalar&, PetscScalar&)’ is ambiguous
 #define PetscPowScalar(a,b)   pow(a,b)

One option that I can think about is to add the :: symbol in the pow definition on PETSc to avoid the overloading, but I'm not sure if that is a good idea/solution, something like this:

#define PetscPowScalar(a,b) ::pow(a,b)

If anybody has a way to include PETSc into OpenFOAM (the simples way will do the job actually) or how can I avoid this overloading I will be really thankful.

[yeharav]

Hi,

I think that namespaces should solve this.

Do you use the OF namespace?
that is do you have

using namespace Foam;

in your code?

[palarcon]

Originally Posted by yeharav

Hi,

I think that namespaces should solve this.

Do you use the OF namespace?
that is do you have

using namespace Foam;

in your code?

I just did that and nothing changes, there is still conflict between OpenFOAM pow definition and PETSc pow definition.

[yeharav]

Hi,

Sorry for confusing you, you should not use

using namespace Foam

in order to segregate between the two namespaces.

However you said that it doesn't work even without it...
Thats interesting because the pow (at leasat for the geometricFields) was defined inside the Foam namespace.

I couldn't find another definition of pow in OF (at least not in OF-7).

[palarcon]

What I'm doing is to use at the same time PETSc (to perform an optimization) with OpenFOAM and it happens that both have a definition for the pow operator.
Either if I use

using namespace foam;

or not, nothing changes, the operator is still overloaded.

A temporary solution (and the simplest one that I found until now) is to add :: into the PETSc pow definition (because I prefer to modify anything but OpenFOAM, following the coding philosophy of my projet).

[olesen]

There is no quick solution to this, other than pretty much what you've done. You cannot, however, in general use the "::" qualifier since PETSc is pure C.

On the assumption that someone, somewhere has included <cmath>, you could have the following - but you'd probably wish that the PETSc team changes this upstream:

#ifdef __cplusplus
#define PetscPowScalar(a,b) std::pow(a,b)
#else
#define PetscPowScalar(a,b)   pow(a,b)
#endif

[palarcon]

Originally Posted by olesen

There is no quick solution to this, other than pretty much what you've done. You cannot, however, in general use the "::" qualifier since PETSc is pure C.

On the assumption that someone, somewhere has included <cmath>, you could have the following - but you'd probably wish that the PETSc team changes this upstream:

#ifdef __cplusplus
#define PetscPowScalar(a,b) std::pow(a,b)
#else
#define PetscPowScalar(a,b)   pow(a,b)
#endif

Thank you for your answer. And yes, you are right, I don't want to "modify further" PETSc, in order to avoid future complications within the code.