[granzer]

I see that polyBoundaryMesh class is used in polyMesh class (has-a relationship) to take care of boundary mesh. Why isn't the polyBoundaryMesh class made into nested class inside the polyMesh class like how the GeometricField:: Boundary is a nested class inside GeometricField and takes care of the boundary fields and related boundary conditions.

[olesen]

Stick it on an issue (https://develop.openfoam.com/Develop...nfoam/-/issues).
Can't see any particular advantage to having it nested, but off-hand no particular disadvantage either.

BTW: one general issue with nested classes is that it makes them almost impossible to forward declare (this hit us with the profiling classes). Maybe not a factor here, but figured I might mention it anyhow.

[granzer]

Originally Posted by olesen

Stick it on an issue (https://develop.openfoam.com/Develop...nfoam/-/issues).
Can't see any particular advantage to having it nested, but off-hand no particular disadvantage either.

BTW: one general issue with nested classes is that it makes them almost impossible to forward declare (this hit us with the profiling classes). Maybe not a factor here, but figured I might mention it anyhow.

What do you think about the case where we just import the surface mesh(I have never tried this)? Would polyBoundaryMesh as a inner class still work in such a case or will having it as a seperate class be advantageous.

(I didn't know nested class couldn't be forward declared outside the enclosing class. That helped me learn something new .)

[olesen]

In the meantime can't really see any advantages for nesting polyBoundaryMesh. Could maybe add as a typedef inside polyMesh I suppose, but still can't see what it helps.