[Sarah13]

I am trying to update a solver (artificially thickened flame) from OF2.2.2 to OF8. There is a class named efficiencyFunction that uses delta as variable, whose input arguments are in the form (for OF2.2.2):
delta_(LESdelta::New("delta", U.mesh(), *this))


But the LESdelta's "New" function in OF8 take input arguments in the form:
Foam::autoPtr<Foam::LESdelta> Foam::LESdelta::New
(
const word& name,
const momentumTransportModel& turbulence,
const dictionary& dict
)


which was in older version OF2.2.2 is of the form:
Foam::autoPtr<Foam::LESdelta> Foam::LESdelta::New
(
const word& name,
const fvMesh& mesh,
const dictionary& dict
)


so when I am trying to compile it, it is giving me an error as:
no matching function for call to ‘Foam::LESdelta::New(const char [6], const Mesh&, Foam::efficiencyFunction&)’


If anyone can get my query (if it is clear enough) and respond to it as to what changes should I make, I would be really grateful.

[Tobi]

Hey Sarah,

as you can see and already pointed out, the constructors are different:

NEW

Foam::autoPtr<Foam::LESdelta> Foam::LESdelta::New
(
const word& name,
const momentumTransportModel& turbulence,
const dictionary& dict
)

OLD

Foam::autoPtr<Foam::LESdelta> Foam::LESdelta::New
(
const word& name,
const fvMesh& mesh,
const dictionary& dict
)

Hence you are not allowed to put the mesh object for creating the new LESdelta. Simply check out newer solvers how it is implemented there.

Example given, the LESdelta::New function needs e.g., the following argument: https://github.com/OpenFOAM/OpenFOAM...teFields.H#L42
Meaning that you call needs to be something like that:

auto myNewObject = LESdelta::New("whatEver", turbulence, dict);

Therefore, you need to get access to that object in your file you need.
E.g.

• In your solver, you need to send the "turbulence" object to your class you need it (probably by implementing some functions)
• After you stored a reference/pointer in the class, you can access it

[Sarah13]

Hi Thanks for your reply, I am still not able to solve the problem.
However I wish to access LESDelta in my solver code, can anyone please help me how to can I use the LES delta, as I can't find any solver which uses LES delta in their formula to which I can refer to?

[kont87]

Originally Posted by Sarah13

Hi Thanks for your reply, I am still not able to solve the problem.
However I wish to access LESDelta in my solver code, can anyone please help me how to can I use the LES delta, as I can't find any solver which uses LES delta in their formula to which I can refer to?

Hi,

Did you make any progress on accessing the delta? My solver uses it for calculating scalar variances of mixture fraction variance. I’d be glad if anyone could help.
Thanks

[Sarah13]

Hi Serg
I calculated delta in my code itself using the mesh information. For 3-D it would be pow(mesh.V(),1.0/3.0). Note that it is only valid for cubeRootVol type of delta. For other type of delta you can maybe refer to their source code to find out how they are calculated.
Also to implement it properly you can refer to the source file of cubeRootVol delta.

[kont87]

I was using this code snippet to reach delta, but it seems its an old version, so It does not return anything.

PHP Code:

    if (mesh.objectRegistry::foundObject<volScalarField>("delta"))
    {       

      const volScalarField& delta = mesh_.objectRegistry::lookupObject<volScalarField>("delta");
      LESdelta_ = delta;
    } 


Anybody have any idea to solve the problem, for OF version 7 or higher?

[Tobermory]

This may not work, but is a shortcut that is worth trying - essentially it's the "banana" trick. Try modifying your code snippet to:

//if (mesh.objectRegistry::foundObject<volScalarField>("delta"))
//{       
      const volScalarField& delta = mesh_.objectRegistry::lookupObject<volScalarField>("delta");
//      LESdelta_ = delta;
//    }

recompile and run ... ie force the solver to do the registry assignment; the solver should then crash out saying that it can't find "delta" in the registry. But here's the useful bit - it should also list all the objects it does have in the registry, and so if it is stored with a different name then you'll be able to spot it and use the name. Otherwise, you'll need to get at it a different way, through the turbulence class structure.

[kont87]

Originally Posted by Tobermory

This may not work, but is a shortcut that is worth trying - essentially it's the "banana" trick. Try modifying your code snippet to:

//if (mesh.objectRegistry::foundObject<volScalarField>("delta"))
//{       
      const volScalarField& delta = mesh_.objectRegistry::lookupObject<volScalarField>("delta");
//      LESdelta_ = delta;
//    }

recompile and run ... ie force the solver to do the registry assignment; the solver should then crash out saying that it can't find "delta" in the registry. But here's the useful bit - it should also list all the objects it does have in the registry, and so if it is stored with a different name then you'll be able to spot it and use the name. Otherwise, you'll need to get at it a different way, through the turbulence class structure.

Thank you Tobermary, I guess I need to access it in a different way. I changed "delta" in the code I provided to "bananas", however, It does not include "delta", since the implementation is changed and delta can not be accessed through turbulence pointer. Do you have any other suggestions?

Best regards

[Tobermory]

Strange. I added the following into a clone of pisoFoam, in OF8, and it worked fine:

    Info << "-------------------------------------" << endl;

    volScalarField LESdelta
    (
        IOobject
        (
            "LESdelta",
            runTime.timeName(),
            mesh,
            IOobject::NO_READ,
            IOobject::NO_WRITE
        ),
        mesh,
        dimensionedScalar("LESdelta", dimLength, SMALL)
    );

    if (mesh.objectRegistry::foundObject<volScalarField>("delta"))
    {
        Info << "Found it!" << endl;
        const volScalarField& delta =
            mesh.objectRegistry::lookupObject<volScalarField>("delta");
        LESdelta = delta;
    }
    else
    {
        Info << "No joy I am afraid" << endl;
    }
    Info << LESdelta << endl;

    Info << "-------------------------------------" << endl;

... i.e. it printed out the contents of the delta field.

[Tobermory]

PS, check your syntax:

    if (mesh.objectRegistry::foundObject<volScalarField>("delta"))
    {
      const volScalarField& delta = mesh_.objectRegistry::lookupObject<volScalarField>("delta");
      LESdelta_ = delta;
    }

in line 3, you probably mean mesh rather than mesh_, right?

[kont87]

Originally Posted by Tobermory

Strange. I added the following into a clone of pisoFoam, in OF8, and it worked fine:

    Info << "-------------------------------------" << endl;

    volScalarField LESdelta
    (
        IOobject
        (
            "LESdelta",
            runTime.timeName(),
            mesh,
            IOobject::NO_READ,
            IOobject::NO_WRITE
        ),
        mesh,
        dimensionedScalar("LESdelta", dimLength, SMALL)
    );

    if (mesh.objectRegistry::foundObject<volScalarField>("delta"))
    {
        Info << "Found it!" << endl;
        const volScalarField& delta =
            mesh.objectRegistry::lookupObject<volScalarField>("delta");
        LESdelta = delta;
    }
    else
    {
        Info << "No joy I am afraid" << endl;
    }
    Info << LESdelta << endl;

    Info << "-------------------------------------" << endl;

... i.e. it printed out the contents of the delta field.

Interesting, it is maybe because I was trying to reach it in turbulenceModel constructor, that must be why.

Regards