[jairoandres]

Dear all

I am working on a solution for OpenFOAM issue #2289 (https://develop.openfoam.com/Develop.../-/issues/2289), which affects both versions of OpenFOAM. The bug occurs when a particle-containing cell of level > 1, belonging to a wall boundary is unrefined.

One approach would be protecting the boundary-cells from unrefinement, which is discussed here: dynamicRefineFvMesh - Protect cells from refinement (boundary). However, this approach is not convenient as it blocks refinement in wall cells, which very often need to be refined.

The other option would be protecting from refinement cell containing particles. My idea is modifying the dynamicRefineFvMesh file, including something like:

forAll(cells(), celli)
{
const cell& nParcels = cells()[celli];
if (nParcels.parcelNumberinCell > 0)
{
protectedCell_.set(celli);
}

I am aware that there is no such thing as "parcelNumberinCell". What would be the best approach?

I am aware that p.cell() would return the cell number containing the parcel, but then it would require a loop through all parcels. This would be the same for cellOccupancy, right?

Any ideas?

Best regard

J.A. Gutiérrez

[joshwilliams]

Originally Posted by jairoandres

I am aware that p.cell() would return the cell number containing the parcel, but then it would require a loop through all parcels. This would be the same for cellOccupancy, right?

Hi,
Your point about cellOccupancy requiring a loop over all particles is incorrect, if I have understood your task correctly. You can simply do `cellOccupancy.size()', thus eliminating the need to loop over all particles. Here is a minimum example based on a time I have done something similar for cells containing no particles:

const polyMesh& pmesh = this->owner().mesh();
List<DynamicList<typename CloudType::parcelType*>>& cellOccupancy =
    this->owner().cellOccupancy();

// check all cells containing particles
forAll(pmesh.cells(), celli)
{
    if ( cellOccupancy[celli].size() == 0 )
    {
        // do something
    }
    else
    {
        // do something else
    }
}

Best,
Josh

[jairoandres]

Thank you Josh.. I am going to test it this week and I will let you know what happens.

Jairo.

[joshwilliams]

Any luck, Jairo?

[jairoandres]

Hi Josh, no I have not had any luck yet. I think my OpenFOAM C++ skills are lacking for this task, please correct me if I am wrong.

I suppose the modification must be included in the dynamicRefineFvMesh, as the protected cells (particle-containing) must be evaluated each time the mesh refinement / unrefinement is going to occur. I added something like this:

const polyMesh& pmesh = this->owner().mesh();
List<DynamicList<typename CloudType::parcelType*>>& cellOccupancy = this->owner().cellOccupancy();
forAll(pmesh.cells(), celli)
{
    if ( cellOccupancy[celli].size() > 0 )
    {
       protectedCell_.set(celli);
    }
    
}

However, as far as I understand, the List<DynamicList<typename CloudType returns a list for each parcel and I don't think it can be called from dynamicRefineFvMesh. The compiling error is the following:

dynamicRefineFvMesh/dynamicRefineFvMesh.C: In member function ‘virtual bool Foam::dynamicRefineFvMesh::init(bool)’:
dynamicRefineFvMesh/dynamicRefineFvMesh.C:1174:46: error: ‘const labelUList {aka const class Foam::UList<int>}’ has no member named ‘mesh’; did you mean ‘test’?
        const polyMesh& pmesh = this->owner().mesh();
                                              ^~~~
                                              test
dynamicRefineFvMesh/dynamicRefineFvMesh.C:1175:49: error: template argument 1 is invalid
 List<DynamicList<typename CloudType::parcelType*>>& cellOccupancy =
                                                 ^~
dynamicRefineFvMesh/dynamicRefineFvMesh.C:1175:53: error: ‘cellOccupancy’ was not declared in this scope
 List<DynamicList<typename CloudType::parcelType*>>& cellOccupancy =
                                                     ^~~~~~~~~~~~~
dynamicRefineFvMesh/dynamicRefineFvMesh.C:1176:19: error: ‘const labelUList {aka const class Foam::UList<int>}’ has no member named ‘cellOccupancy’
     this->owner().cellOccupancy();
                   ^~~~~~~~~~~~~
dynamicRefineFvMesh/dynamicRefineFvMesh.C:1176:33: error: template argument 1 is invalid
     this->owner().cellOccupancy();
                                 ^

I've have included the intermediate library to "#include "kinematicCloud.H", where cellOccupancy is defined, but that specific error still persists.

Any help is completely welcomed

[mrishi]

It appears you are using 'this' from within the dynamicFvMesh file, but trying to access cloud members? Using 'this' will only work from within the cloud functions.
Are you able to access the mesh using something like

const polyMesh& mesh = cloud.pMesh();

[jairoandres]

Originally Posted by mrishi

It appears you are using 'this' from within the dynamicFvMesh file, but trying to access cloud members? Using 'this' will only work from within the cloud functions.
Are you able to access the mesh using something like

const polyMesh& mesh = cloud.pMesh();

Thank you mrishi, cloud was not declared but I added #include "cloud.H" at the start and the error stopped appearing. Still, pMesh, cellOccupancy are still undefined. What is weird to me(or beyond my knowledge) is that pMesh is supposed to be defined in cloud.H.

 dynamicRefineFvMesh/dynamicRefineFvMesh.C:1176:36: error: expected primary-expression before ‘.’ token
        const polyMesh& mesh = cloud.pMesh();
                                    ^
dynamicRefineFvMesh/dynamicRefineFvMesh.C:1178:49: error: template argument 1 is invalid
 List<DynamicList<typename CloudType::parcelType*>>& cellOccupancy = cloud.pMesh().cellOccupancy();
                                                 ^~
dynamicRefineFvMesh/dynamicRefineFvMesh.C:1178:53: error: ‘cellOccupancy’ was not declared in this scope
 List<DynamicList<typename CloudType::parcelType*>>& cellOccupancy = cloud.pMesh().cellOccupancy();
                                                     ^~~~~~~~~~~~~
dynamicRefineFvMesh/dynamicRefineFvMesh.C:1178:97: error: template argument 1 is invalid
 pename CloudType::parcelType*>>& cellOccupancy = cloud.pMesh().cellOccupancy();

dynamicRefineFvMesh/dynamicRefineFvMesh.C:1181:8: error: ‘pMesh’ was not declared in this scope
 forAll(pMesh.cells(), celli)

I have attached the dynamicRefineFvMesh file I am using (OF-2012) if you wish to take a look into it. Thanks!. Solving this issue should (in theory) fix a serious bug of openfoam when using AMR with particles.

Here is the attached file:
dynamicRefineFvMesh.C
All the modifications are commented as: // JAG