[user]

Hi foamers,


I use scalarCodedSource for adding mass for a phase in twoPhaseEulerFoam, which used to work in OpenFoam v2012. The same code gives an error "Not implemented" in v2112. A very simple example for fvOptions is:

/*--------------------------------*- C++ -*----------------------------------*\
| =========                 |                                                 |
| \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox           |
|  \\    /   O peration     | Version:  v2112                                 |
|   \\  /    A nd           | Website:  www.openfoam.com                      |
|    \\/     M anipulation  |                                                 |
\*---------------------------------------------------------------------------*/
FoamFile
{
    version     2.0;
    format      ascii;
    class       dictionary;
    object      fvOptions;
}
// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //

testsource
{
    type            scalarCodedSource;
    active          true;
    name           sourceTime; 
   
    scalarCodedSourceCoeffs
    {
        selectionMode   all;
        fields          (thermo:rho.air); 

        codeInclude
        #{
        #};

        codeCorrect
        #{
            Pout<< "**codeCorrect**" << endl;
        #};

        codeAddSup
        #{           
            Info << " addSup " << endl; 
        #};

        codeConstrain
        #{
            Pout<< "**codeConstrain**" << endl;
        #};            

        code
        #{
            $codeInclude
            $codeCorrect
            $codeAddSup
            $codeSetValue
        #};
    }

If I copy this to the bubbleColumn-tutorial (in constant-folder) I get the expected result (giving output text while running) with OF v2012. In OF v2112 I get the error:

--> FOAM FATAL ERROR: (openfoam-2112)
Not implemented

    From virtual void Foam::fv::sourceTimeFvOptionscalarSource::addSup(const volScalarField&, Foam::fvMatrix<double>&, Foam::label)
    in file /home/user/user-v2112/run/bubbleColumn/constant/fvOptions.testsource.scalarCodedSourceCoeffs at line 59.

FOAM aborting

#0  Foam::error::printStack(Foam::Ostream&) at ??:?
#1  Foam::error::simpleExit(int, bool) at ??:?
#2  Foam::error::exiting(int, bool) at ??:?
#3  Foam::tmp<Foam::fvMatrix<double> > Foam::fv::optionList::operator()<double>(Foam::GeometricField<double, Foam::fvPatchField, Foam::volMesh> const&, Foam::GeometricField<double, Foam::fvPatchField, Foam::volMesh>&, Foam::word const&) at ??:?
#4  ? at ??:?
#5  __libc_start_main in /lib64/libc.so.6
#6  ? at ??:?

I guess something changed with accesing the thermofunctions but I couldn't find any big differences for the twoPhaseEulerFoam-solver or twoPhaseSystem, so I guess the problem is something deeper in the code.


Did somebody experience similar issues? A quick test with simpleFoam and the field "k" worked as expected in v2012 and 2112.


Any help is appreciated.


Ulf

[olesen]

How does it look if you also define codeAddSupRho ?
Seems to have been missed out on the release notes/upgrade-guides but see the following commit for some info:


https://develop.openfoam.com/Develop...b8b3c23a154725




FWIW the older code that "worked", probably didn't actually use the density.

[user]

Thank your very much for your time and fast answer! As you guessed, codeAddSupRho is the correct way and it seems to work. I'm feeling a little bit ashamed...

I will check the older cases and try to read the release-notes next time more carefully

Ulf

[olesen]

Originally Posted by user

Thank your very much for your time and fast answer! As you guessed, codeAddSupRho is the correct way and it seems to work. I'm feeling a little bit ashamed...

I will check the older cases and try to read the release-notes next time more carefully

Ulf

Actually I'm not even sure it shows up in the release notes properly at all. Might have slipped under the radar.

[saladbowl]

Just for clarification,

If I wish to add a source to the energy equation in rhoPimpleFoam by using fvOptions, then I should define this source in codeAddSupRho? If given source is in units of W/mˆ3, do I need to multiply by rho?

I noticed that in EEqn.H, fvOptions is called with the operator() in the form fvOptions (rho, he).

{
    volScalarField& he = thermo.he();

    fvScalarMatrix EEqn
    (
        fvm::ddt(rho, he) + fvm::div(phi, he)
      + fvc::ddt(rho, K) + fvc::div(phi, K)
      + (
            he.name() == "e"
          ? fvc::div
            (
                fvc::absolute(phi/fvc::interpolate(rho), U),
                p,
                "div(phiv,p)"
            )
          : -dpdt
        )
      - fvm::laplacian(turbulence->alphaEff(), he)
     ==
        fvOptions(rho, he)
    );

If I understand the C++ code correctly in fvOptionListTemplates.C, then this will run the following lines of code..

template<class Type>
Foam::tmp<Foam::fvMatrix<Type>> Foam::fv::optionList::operator()
(
    const volScalarField& rho,
    GeometricField<Type, fvPatchField, volMesh>& field,
    const word& fieldName
)
{
    checkApplied();

    const dimensionSet ds
    (
        rho.dimensions()*field.dimensions()/dimTime*dimVolume
    );

    tmp<fvMatrix<Type>> tmtx(new fvMatrix<Type>(field, ds));
    fvMatrix<Type>& mtx = tmtx.ref();

    forAll(*this, i)
    {
        option& source = this->operator[](i);

        label fieldi = source.applyToField(fieldName);

        if (fieldi != -1)
        {
            addProfiling(fvopt, "fvOption()." + source.name());

            source.setApplied(fieldi);

            if (source.isActive())
            {
                if (debug)
                {
                    Info<< "Applying source " << source.name() << " to field "
                        << fieldName << endl;
                }

                source.addSup(rho, mtx, fieldi);
            }
        }
    }

    return tmtx;
}

From the above, it is clear that the expected dimensions are `rho.dimensions()*field.dimensions()/dimTime*dimVolume`. I have a bit of difficulty understanding exactly what the call to source.addSup(rho, mtx, fieldi) results in (and where that code is), but I suspect it may insert the scalarCodedSource code from the fvOptions file. Having said that, I imagine that the units for the source should be W/kg, so it is important to multiply a volumetric source by rho. Am I correct in my assessment?

[dasa]

Originally Posted by saladbowl

Just for clarification,

If I wish to add a source to the energy equation in rhoPimpleFoam by using fvOptions, then I should define this source in codeAddSupRho? If given source is in units of W/mˆ3, do I need to multiply by rho?

I noticed that in EEqn.H, fvOptions is called with the operator() in the form fvOptions (rho, he).

{
    volScalarField& he = thermo.he();

    fvScalarMatrix EEqn
    (
        fvm::ddt(rho, he) + fvm::div(phi, he)
      + fvc::ddt(rho, K) + fvc::div(phi, K)
      + (
            he.name() == "e"
          ? fvc::div
            (
                fvc::absolute(phi/fvc::interpolate(rho), U),
                p,
                "div(phiv,p)"
            )
          : -dpdt
        )
      - fvm::laplacian(turbulence->alphaEff(), he)
     ==
        fvOptions(rho, he)
    );

If I understand the C++ code correctly in fvOptionListTemplates.C, then this will run the following lines of code..

template<class Type>
Foam::tmp<Foam::fvMatrix<Type>> Foam::fv::optionList::operator()
(
    const volScalarField& rho,
    GeometricField<Type, fvPatchField, volMesh>& field,
    const word& fieldName
)
{
    checkApplied();

    const dimensionSet ds
    (
        rho.dimensions()*field.dimensions()/dimTime*dimVolume
    );

    tmp<fvMatrix<Type>> tmtx(new fvMatrix<Type>(field, ds));
    fvMatrix<Type>& mtx = tmtx.ref();

    forAll(*this, i)
    {
        option& source = this->operator[](i);

        label fieldi = source.applyToField(fieldName);

        if (fieldi != -1)
        {
            addProfiling(fvopt, "fvOption()." + source.name());

            source.setApplied(fieldi);

            if (source.isActive())
            {
                if (debug)
                {
                    Info<< "Applying source " << source.name() << " to field "
                        << fieldName << endl;
                }

                source.addSup(rho, mtx, fieldi);
            }
        }
    }

    return tmtx;
}

From the above, it is clear that the expected dimensions are `rho.dimensions()*field.dimensions()/dimTime*dimVolume`. I have a bit of difficulty understanding exactly what the call to source.addSup(rho, mtx, fieldi) results in (and where that code is), but I suspect it may insert the scalarCodedSource code from the fvOptions file. Having said that, I imagine that the units for the source should be W/kg, so it is important to multiply a volumetric source by rho. Am I correct in my assessment?

Hi saladbowl, have you implemented this custom source under "codeAddSupRho", I am facing difficulty applying this. If you have implemented this, could you please provide some information on how the source is applied here?