[Sunmax]

I found that when using udf to output the mesh node coordinates, the number of the nodes were incredibly large.

I don't know what makes this wrong, so I put the udf below and hope someone can give a reasonable explanation.

#include"udf.h"
#define PLATE_ID 5  

DEFINE_EXECUTE_AT_END(Coordinate)
{  
    Domain *d = Get_Domain(1);                
    Thread *tf = Lookup_Thread(d, PLATE_ID);   
    face_t f;
    FILE *NX, *NY, *Num;
    int n, count = 0;
    Node *v;
    real x, y;
    
    
    begin_f_loop(f, tf)
    {
    
    	f_node_loop(f, tf, n)
    	{
    		v = F_NODE(f, tf, n);
    		x = NODE_X(v);
    		y = NODE_Y(v);
    	    
		NX = fopen("node_x.txt", "at+");   
    		fprintf(NX, "%f,", x);
    		fclose(NX);
                NY = fopen("node_y.txt", "at+");
                fprintf(NY, "%f,", y);
                fclose(NY);
                ++count;
    	}
    }
    end_f_loop(f, tf);
    
    Num = fopen("Num_nodes.txt", "at+");
    fprintf(Num, "Num of nodes=%d", count);
    fclose(Num);
}

In my case, the real number of nodes on the plate is 2036, but that is 4072 in the Num_nodes.txt, exactly two times of the real one.

[vinerm]

The nodes are not unique for each face but are shared. The number of faces sharing a node depends on the type of mesh. Therefore, many nodes are visited multiple times and the count goes wrong.

[Sunmax]

Originally Posted by vinerm

The nodes are not unique for each face but are shared. The number of faces sharing a node depends on the type of mesh. Therefore, many nodes are visited multiple times and the count goes wrong.

Thank you very much for the explanation of the mechanism. I need to use the coordinates to control the dynamic mesh deformation in a special way, although I found that the udf(another one) could work well in serial processing which could not be used in parallel processing. So I guess it is the output-coordinates that causes the problem.

[vinerm]

What do you mean by output coordinates? There is no problem here except that the nodes are being visited multiple times.

[Sunmax]

Originally Posted by vinerm

What do you mean by output coordinates? There is no problem here except that the nodes are being visited multiple times.

I need the coordinates of two adjacent nodes to calculate the distance between them， the udf macro NODE_X(v) could not be used as NODE_X(v+1) so I have to output the coordinates. But there is another problem that the order of the coordinates is messy.

[vinerm]

v and v+1 may or may not be adjacent. Try using v->next, though I am not clear about the structure but node structure most likely is based on linked list and you should be able to access next node using next. But even with that, it is not guaranteed that next node is also adjacent node. So, the fool proof method is to compare the coordinates.

[Sunmax]

Originally Posted by vinerm

v and v+1 may or may not be adjacent. Try using v->next, though I am not clear about the structure but node structure most likely is based on linked list and you should be able to access next node using next. But even with that, it is not guaranteed that next node is also adjacent node. So, the fool proof method is to compare the coordinates.

I found another interesting issue if I add the if(n==0) before the node_loop, the nodes will be visited only one time. But why?

begin_f_loop(f, tf)
{
     f_node_loop(f, tf, n)
    {  
	if ( n==0 ) 
	{ 
	   F_AREA(A, f, tf);
	   v=F_NODE(f, tf, n);
	   ve = F_V(f, tf);
  
	   NV_VS(pl,=,A,*,F_P(f,tf));
	   NV_VS(pl,=,pl,*,ve);
	   NV_V(pl_tot, +=,pl);
	   
	}
    }
}
end_f_loop(f,tf);

[vinerm]

That's because the loop goes over values of n. With If condition, you are constraining the loop to one instance, only when n = 0. So, the loop is executed only once.

[Sunmax]

Originally Posted by vinerm

That's because the loop goes over values of n. With If condition, you are constraining the loop to one instance, only when n = 0. So, the loop is executed only once.

And one more question, are there any side effects if I use the if-condition to constrain the node_loop?

[vinerm]

There are no side-effects, just the effects. The parts of the code within the confines of the If condition will be executed only if the condition is true. If you are thinking of using If to control the number of loops, then the logic wrong. The loop goes over all the nodes only once, there is no problem with that. The issue you are facing is because nodes are not unique to the cells or the faces. Each node is shared.