|
[Sponsors] |
What's the reason of two turbulencemodels folder? |
|
LinkBack | Thread Tools | Search this Thread | Display Modes |
March 21, 2014, 14:28 |
What's the reason of two turbulencemodels folder?
|
#1 |
Senior Member
Daniel WEI (老魏)
Join Date: Mar 2009
Location: Beijing, China
Posts: 689
Blog Entries: 9
Rep Power: 21 |
What's the reason of two turbulenceModels folder? What's the philosophy behind this new folder restructuring?
__________________
~ Daniel WEI ------------- Boeing Research & Technology - China Beijing, China |
|
March 21, 2014, 15:06 |
|
#2 |
Retired Super Moderator
Bruno Santos
Join Date: Mar 2009
Location: Lisbon, Portugal
Posts: 10,978
Blog Entries: 45
Rep Power: 128 |
Hi Daniel,
I'd like you to meet the Release Notes for OpenFOAM 2.3.0: http://www.openfoam.org/version2.3.0/ Now, when you get to the "Multiphase" page: http://www.openfoam.org/version2.3.0/multiphase.php - you'll find the section "Multiphase Turbulence" after a bit of reading. There everything is mostly explained. Beyond that, what I can say is this (actually, mostly just rant about how great it is ): OpenFOAM is chock-full with C++ templates, so much that at this point in time, the flag "template-depth" is set to 100! https://github.com/OpenFOAM/OpenFOAM...c48/c%2B%2B#L9 The advantage of this is that it allows us to easily (i.e., after we understand how templates in OpenFOAM work):
Best regards, Bruno
__________________
|
|
March 21, 2014, 15:24 |
|
#3 |
Senior Member
Daniel WEI (老魏)
Join Date: Mar 2009
Location: Beijing, China
Posts: 689
Blog Entries: 9
Rep Power: 21 |
Thanks! But with all due respect, I still feel putting two identical names (except letter "T") under the same src/ folder is not a good idea.
__________________
~ Daniel WEI ------------- Boeing Research & Technology - China Beijing, China |
|
March 21, 2014, 16:18 |
|
#4 | |
Retired Super Moderator
Bruno Santos
Join Date: Mar 2009
Location: Lisbon, Portugal
Posts: 10,978
Blog Entries: 45
Rep Power: 128 |
Quote:
If you have a look into the folder "src/OpenFOAM/lnInclude", you'll see several files that only differ in the case of the first letter. The simplest is "Vector.H" vs "vector.H". It's due to nomenclature used in OpenFOAM:
My belief is that is this way, in order to make it perfectly clear to those who look at OpenFOAM: every single detail, no matter how small, is more important than one is willing to believe. Of course that once we start delving into OpenFOAM's inner workings, we start finding class files that are not abiding to this nomenclature, because they belong to the "fvc" namespace. Or because the model is the name of the author(s) of said model. Details, details, details... it's all about the details But let's face it:
Ah, then there's another issue you might find out sooner or later: did you know that there are files in OpenFOAM's source code that have the same identical name, but don't even belong in different namespaces, even though they are meant for different features? Here's some examples I can remember+find:
|
||
March 21, 2014, 16:23 |
|
#5 |
Senior Member
Daniel WEI (老魏)
Join Date: Mar 2009
Location: Beijing, China
Posts: 689
Blog Entries: 9
Rep Power: 21 |
I am 100% okay with files (you explained it very well), but as top-level source folders under src/, hmm, sorry, I just can't get it, I don't think it's a good practice.
__________________
~ Daniel WEI ------------- Boeing Research & Technology - China Beijing, China |
|
March 21, 2014, 16:38 |
|
#7 |
Senior Member
Daniel WEI (老魏)
Join Date: Mar 2009
Location: Beijing, China
Posts: 689
Blog Entries: 9
Rep Power: 21 |
4th level, let them. But as a top level folder, it does not look very "organized". Sorry, maybe it's just my personal opinion,
__________________
~ Daniel WEI ------------- Boeing Research & Technology - China Beijing, China |
|
May 25, 2014, 19:05 |
|
#8 |
Retired Super Moderator
Bruno Santos
Join Date: Mar 2009
Location: Lisbon, Portugal
Posts: 10,978
Blog Entries: 45
Rep Power: 128 |
Hi Daniel,
Just a mild update on this topic: if I interpreted correctly a comment on the bug tracker sometime ago, it seems that the old "turbulenceModels" folder may be deprecated in future releases, as soon as they are able to port everything to the new template mechanism. If my memory doesn't fail me, the comment in question is the last one here: http://www.openfoam.org/mantisbt/view.php?id=1259 Best regards, Bruno
__________________
|
|
|
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
Writing IOdictionary to user-defined folder | Arnoldinho | OpenFOAM Programming & Development | 3 | June 16, 2021 04:04 |
icoFsiFoam folder structure OF 2.2.1 | philipp1 | OpenFOAM Running, Solving & CFD | 1 | January 25, 2014 17:08 |
I want to arrange all source file into Single Folder :Debate Urgent Help | hhh | OpenFOAM | 3 | July 27, 2013 05:15 |
[snappyHexMesh] Folder structure from snappyHexMesh | elisenda | OpenFOAM Meshing & Mesh Conversion | 3 | January 6, 2010 03:52 |
Discussion: Reason of Turbulence!! | Wen Long | Main CFD Forum | 3 | May 15, 2009 09:52 |