[Andrea_85]

Hello,

i am trying to modify the interfaceProperties lib. To do this i created a new library (say "myInterfaceProperties"), which, for the moment, looks exactly as the original one. The only difference is that i am trying to pass more fields to the library. I modified the constructors part in interfaceProperties.C as follow (red parts are new)

// * * * * * * * * * * * * * * * * Constructors  * * * * * * * * * * * * * * //
Foam::myInterfaceProperties::myInterfaceProperties
(
    const volScalarField& alpha1,
    const volVectorField& U,
    const volScalarField& DeltaX,
    const volScalarField& DeltaY,
    const IOdictionary& dict
)
:    
    alpha1_(alpha1),
    U_(U),
    dx_(DeltaX),
    dy_(DeltaY),

Then, i added the declaration of the two new variables in interfaceProperties.H

 
const volScalarField& alpha1_;
const volVectorField& U_;
const volScalarField& dx_;
const volScalarField& dy_;

DeltaX and DeltaX are defined in the main code as volScalarField.
I called the new library in createField.H as

myInterfaceProperties interface(alpha1, U, DeltaX, DeltaY, twoPhaseProperties);

I have successfully compiled both the new library and the main code but when i try to run the code i get this error just after the library is called

Create mesh for time = 0


PIMPLE: Operating solver in PISO mode

Reading field p_rgh

Reading field U

Reading/calculating face flux field phi

Reading transportProperties

Selecting incompressible transport model Newtonian
Selecting incompressible transport model Newtonian

#0  Foam::error::printStack(Foam::Ostream&) at ??:?
#1  Foam::sigSegv::sigHandler(int) at ??:?
#2   in "/lib/x86_64-linux-gnu/libc.so.6"
#3  Foam::myInterfaceProperties::myInterfaceProperties(Foam::GeometricField<double, Foam::fvPatchField, Foam::volMesh> const&, Foam::GeometricField<Foam::Vector<double>, Foam::fvPatchField, Foam::volMesh> const&, Foam::GeometricField<double, Foam::fvPatchField, Foam::volMesh> const&, Foam::GeometricField<double, Foam::fvPatchField, Foam::volMesh> const&, Foam::IOdictionary const&) at ??:?
#4
 at ??:?
#5  __libc_start_main in "/lib/x86_64-linux-gnu/libc.so.6"
#6
 at ??:?
Segmentation fault (core dumped)

Note that i am not even using DeltaX DeltaY, this was just a test to see if the new variables were correctly passed to the new library and it seems they are not.

Any idea about the error?

Andrea

[mkraposhin]

Hi!

Which OF version are you using? OF2.4.0 or less?

Did you pointed your Make/options file to new library, like that:

EXE_INC =
    -I$(LIB_SRC)/transportModels/twoPhaseMixture/lnInclude \
    -I$(LIB_SRC)/transportModels \
    -I$(LIB_SRC)/transportModels/incompressible/lnInclude \
    -I$myInterfaceProperties/lnInclude \
    -I$(LIB_SRC)/turbulenceModels/incompressible/turbulenceModel \
    -I$(LIB_SRC)/finiteVolume/lnInclude \
    -I$(LIB_SRC)/meshTools/lnInclude \
    -I$(LIB_SRC)/fvOptions/lnInclude \
    -I$(LIB_SRC)/sampling/lnInclude

EXE_LIBS = \
    -L$(FOAM_USER_LIBBIN) \
    -ltwoPhaseMixture \
    -lmyInterfaceProperties \
    -ltwoPhaseProperties \
    -lincompressibleTurbulenceModel \
    -lincompressibleRASModels \
    -lincompressibleLESModels \
    -lfiniteVolume \
    -lmeshTools \
    -lfvOptions \
    -lsampling

In any way the better practice, is to create your own derived class, which inherits standard OpenFOAM class. In this class you can put anything you want.

[Andrea_85]

Hi,

thanks for your reply. I am using 2.3.1
This is exactly what i have done. I created a new solver and linked to it the new libraries. This is how the Make/option file looks like (again in red the new parts)

EXE_INC = \
    -I$(LIB_SRC)/transportModels/twoPhaseMixture/lnInclude \
    -I$(LIB_SRC)/transportModels \
    -I$(LIB_SRC)/transportModels/incompressible/lnInclude \
    -I$(LIB_SRC)/transportModels/interfaceProperties/lnInclude \
    -I$(LIB_SRC)/turbulenceModels/incompressible/turbulenceModel \
    -I$(LIB_SRC)/finiteVolume/lnInclude \
    -I$(LIB_SRC)/fvOptions/lnInclude \
    -I$(LIB_SRC)/meshTools/lnInclude \
    -I$(LIB_SRC)/triSurface/lnInclude \
    -I$(LIB_SRC)/sampling/lnInclude \
    -I./myInterfaceProperties/lnInclude \
    -I./myTwoPhaseProperties/lnInclude

EXE_LIBS = \
    -ltwoPhaseMixture \
    -linterfaceProperties \
    -ltwoPhaseProperties \
    -lincompressibleTransportModels \
    -lincompressibleTurbulenceModel \
    -lincompressibleRASModels \
    -lincompressibleLESModels \
    -lsampling \
    -lfiniteVolume \
    -lfvOptions \
    -ltriSurface \
    -lmeshTools \
    -lmyInterfaceProperties \
    -lmyTwoPhaseProperties

the "old" libraries are still there because i need both. Btw i got no error during the compilation so i am guessing they are properly linked.

Andrea

[mkraposhin]

Originally Posted by Andrea_85

the "old" libraries are still there because i need both. Btw i got no error during the compilation so i am guessing they are properly linked.

Andrea

I think, here is the point of your problem. Your program will work in two cases:
- you will create and will use child class from interfaceProperties
- you will leave only your own version of interfaceProperties

[mkraposhin]

By the way, did you renamed your twoPhaseProperties class?

It looks like a mismatch in data types naming

[Andrea_85]

I quickly tried to remove the link i don't need to the old libraries, recompiled but the error is still there. The Make/option file now is

EXE_INC = \
    -I$(LIB_SRC)/transportModels/twoPhaseMixture/lnInclude \
    -I$(LIB_SRC)/transportModels \
    -I$(LIB_SRC)/transportModels/incompressible/lnInclude \
    -I$(LIB_SRC)/turbulenceModels/incompressible/turbulenceModel \
    -I$(LIB_SRC)/finiteVolume/lnInclude \
    -I$(LIB_SRC)/fvOptions/lnInclude \
    -I$(LIB_SRC)/meshTools/lnInclude \
    -I$(LIB_SRC)/triSurface/lnInclude \
    -I$(LIB_SRC)/sampling/lnInclude \
    -I./myInterfaceProperties/lnInclude \
    -I./myTwoPhaseProperties/lnInclude

EXE_LIBS = \
    -ltwoPhaseMixture \
    -ltwoPhaseProperties \
    -lincompressibleTransportModels \
    -lincompressibleTurbulenceModel \
    -lincompressibleRASModels \
    -lincompressibleLESModels \
    -lsampling \
    -lfiniteVolume \
    -lfvOptions \
    -ltriSurface \
    -lmeshTools \
    -lmyInterfaceProperties \
    -lmyTwoPhaseProperties

The "twoPhaseProperties" lib is there for the alphaContactAngle that i need. In myTwoPhaseProperties ive implemented new Bc for another scalarField (levelSet). The lib has a different name and i changed all the names of all the functions inside. It shouldn't be a problem.

Before, I successfully compiled and used the same solver (with both "old" and "new" interfaceProperties and twoPhaseProperties linked to the main program) but without the additional fields (DeltaX and DeltaY) in the new myInterfaceProperties. Now i need to perform extra calculation and i would like to do it inside the library. That's why i am trying to pass the two fields. I think the error is somewhere there. maybe a wrong variable declaration?

anyway thanks for spending your time on it!

Andrea

[mkraposhin]

There is a type conflict somewhere else. My suggestion is to re-use standard OpenFOAM classes:

in .H:

class myInterfaceProperties
: public interfaceProperties

in .C:

Foam::myInterfaceProperties::myInterfaceProperties
(
    const volScalarField& alpha1,
    const volVectorField& U,
    const volScalarField& DeltaX,
    const volScalarField& DeltaY,
    const IOdictionary& dict
)
:    
    interfaceProperties(alpha1, U, dict)
    dx_(DeltaX),
    dy_(DeltaY),

If you will switch to OF2.3.0 or 2.4.0, i can try to compile and test your, because i think that you are missing something small.

Also, i took part in this thread where this problem was also solved
Adding the Energy Equation to interFoam (OF 2.4.0)

[Andrea_85]

Hello,

after a depth debugging i think i understand (at least) where the error comes from but still i do not know how to fix it. I rewrote the library adding things step by step. Now i am able to corretly pass the two fields DeltaX and DeltaY. The error seems to be generated by another volScalarField i defined inside the library. The variable is named nuGamma_

in myInterfaceProperties.C i added the variable constructor by copy paste nHatf_ from the original interfaceProperties.C

  nuGamma_
    (
        IOobject
        (
            "nuGamma",
            alpha1_.time().timeName(),
            alpha1_.mesh()
        ),
        alpha1_.mesh(),
        dimensionedScalar("nuGamma", dimless, 0.0)
    ),

in myInterfaceProperties.H i added the variable declaration and the member function

/*---------------------------------------------------------------------------*\
                           Class myInterfaceProperties Declaration
\*---------------------------------------------------------------------------*/

class myInterfaceProperties
{
.
.
volScalarField nuGamma_;
.
.
.
 // Member Functions
.
 const volScalarField& nuGamma() const
  {
            return nuGamma_;
   }

I am not using nuGamma, for the moment ive just declared it.
With these lines i got the error in my first post, without these line the code runs with no problem. I really dont see where is the problem.

[mkraposhin]

This problem can be solved easily - check that you are initializing alpha1_ before nuGamma_

If this works, tell me, and i will give explanation later

[Andrea_85]

oh...that was really easy...it works

I did not know it was important the initialization order...i learn new things every day...

thank you very much

andrea

[mkraposhin]

Hi,

Yes, initialization order makes sense.

Sometimes, compiler watches for this - for example, if you declare dx_ and then dy_ in interfaceProperties.H, but initialize dx_ after dy_ in interfaceProperties.C, you will get compiler "warning". This should not generate error in most cases. But it is a good practice to declare and initialize variables in the same order

In your case, you tried to use members of reference to object (volScalarField& alpha1_), which was not initialized.
Reference - is a special type of C++, which must be initialized during it's definition.
In your case, everything, that is between body of constructor " {} " and arguments " : " is treated as the default initialization for members, declared in interfaceProperties.H