[rbabhi]

Dear all,
I am new to OpenFOAM. I have downloaded a solver (SbmFoam) that was created around 2012 (exact OF version is unknown or I have not found it yet).

While compiling in the OF5, I have found several issues while compiling. The first modification I made was to include the following lines to Make/options file:

    -I$(LIB_SRC)/meshTools/lnInclude

Following that I have deleted

#   include "readPISOControls.H"

from Ln69 of SbmFoam.C and added

#   include "pisoControl.H"

on Ln 46. However now when I run

wmake

I get the following errors:

.......5.0/run/SbmFoam$ wmake

Making dependency list for source file SbmFoam.C
g++ -std=c++11 -m64 -Dlinux64 -DWM_ARCH_OPTION=64 -DWM_DP -DWM_LABEL_SIZE=32 -Wall -Wextra -Wold-style-cast -Wnon-virtual-dtor -Wno-unused-parameter -Wno-invalid-offsetof -O3  -DNoRepository -ftemplate-depth-100 -I/opt/openfoam5/src/finiteVolume/lnInclude -I/opt/openfoam5/src/meshTools/lnInclude     -IlnInclude -I. -I/opt/openfoam5/src/OpenFOAM/lnInclude -I/opt/openfoam5/src/OSspecific/POSIX/lnInclude   -fPIC -c SbmFoam.C -o Make/linux64GccDPInt32Opt/SbmFoam.o
SbmFoam.C: In function ‘int main(int, char**)’:
SbmFoam.C:105:31: error: ‘nCorr’ was not declared in this scope
         for (int corr=0; corr<nCorr; corr++)
                               ^
SbmFoam.C:118:26: error: passing ‘const Foam::fvMatrix<Foam::Vector<double> >’ as ‘this’ argument discards qualifiers [-fpermissive]
             UEqn().relax();
                          ^
In file included from /opt/openfoam5/src/finiteVolume/lnInclude/fvMatrix.H:1061:0,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/ddtScheme.C:29,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/ddtScheme.H:342,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/fvcDdt.C:28,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/fvcDdt.H:205,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/fvc.H:44,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/fvCFD.H:8,
                 from SbmFoam.C:45:
/opt/openfoam5/src/finiteVolume/lnInclude/fvMatrix.C:674:6: note:   in call to ‘void Foam::fvMatrix<Type>::relax() [with Type = Foam::Vector<double>]’
 void Foam::fvMatrix<Type>::relax()
      ^
SbmFoam.C:122:44: error: passing ‘const Foam::GeometricField<double, Foam::fvPatchField, Foam::volMesh>::Boundary’ as ‘this’ argument discards qualifiers [-fpermissive]
             p.boundaryField().updateCoeffs();
                                            ^
In file included from /opt/openfoam5/src/OpenFOAM/lnInclude/GeometricField.C:1352:0,
                 from /opt/openfoam5/src/OpenFOAM/lnInclude/GeometricField.H:660,
                 from /opt/openfoam5/src/OpenFOAM/lnInclude/GeometricScalarField.H:38,
                 from /opt/openfoam5/src/OpenFOAM/lnInclude/GeometricFields.H:34,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/volFields.H:37,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/surfaceInterpolationScheme.C:27,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/surfaceInterpolationScheme.H:307,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/surfaceInterpolate.H:41,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/fvc.H:39,
                 from /opt/openfoam5/src/finiteVolume/lnInclude/fvCFD.H:8,
                 from SbmFoam.C:45:
/opt/openfoam5/src/OpenFOAM/lnInclude/GeometricBoundaryField.C:399:6: note:   in call to ‘void Foam::GeometricField<Type, PatchField, GeoMesh>::Boundary::updateCoeffs() [with Type = double; PatchField = Foam::fvPatchField; GeoMesh = Foam::volMesh]’
 void Foam::GeometricField<Type, PatchField, GeoMesh>::Boundary::
      ^
SbmFoam.C:133:42: error: ‘nNonOrthCorr’ was not declared in this scope
             for (int nonOrth=0; nonOrth<=nNonOrthCorr; nonOrth++)
                                          ^
/opt/openfoam5/wmake/rules/General/transform:25: recipe for target 'Make/linux64GccDPInt32Opt/SbmFoam.o' failed
make: *** [Make/linux64GccDPInt32Opt/SbmFoam.o] Error 1

I have just started learning about OF and I was wondering if anyone can guide towards the right direction to troubleshoot this issue with this code.

If it is any help, I am running guest Ubuntu 16.04 on a VirtualBox host Windows 10.

Many thanks.

[MakisH]

There are mainly two problems here.

The first one is:

SbmFoam.C:105:31: error: ‘nCorr’ was not declared in this scope
         for (int corr=0; corr<nCorr; corr++)
                               ^

This means probably that nCorr was declared and defined in the readPISOControls.H file, which you needed to delete.

For this, I think that this commit message and this topic may help. As a first step, try replacing the

for (int corr=0; corr<nCorr; corr++)

with

while (piso.correct())

More errors may follow, I have not tried to compile it.

The second problem is:

SbmFoam.C:118:26: error: passing ‘const Foam::fvMatrix<Foam::Vector<double> >’ as ‘this’ argument discards qualifiers [-fpermissive]
             UEqn().relax();
                          ^

This means that you are trying to make changes on a constant object, which is not allowed. Keep in mind that in OpenFOAM v4.0, there were some changes in handling (const) references. See this topic and the release notes of v4.0 (see "Robust data handling") for more details.

I think you can just solve it if you replace

UEqn().relax()

with

UEqn.ref().relax()

(or maybe with UEqn().ref().relax(), I am not sure right now).

[rbabhi]

Many thanks for your reply. Even after trying your suggestions and fixing several errors, I was left with lists of other issues that I needed to solve. I just gave up at the end and installed OF 1.7.1 and the file compiles perfectly well.

[BSengupta]

Hi!
I apologies for hopping into a previous post. But I find this post relevant to my present problem. I am describing my problem:

I am trying to write some code by modifying densityBasedTurbo in foam extend 4. I am getting the following error:

************************************************** ************************************************** *************************
BSTurboFoam.C:127:25: error: passing ‘const surfaceVectorField {aka const Foam::GeometricField<Foam::Vector<double>, Foam::fvsPatchField, Foam::surfaceMesh>}’ as ‘this’ argument discards qualifiers [-fpermissive]
dbnsFlux.dotX() = mrfZones.faceU();

**************************************************
In BSTurboFoam.C : dbnsFlux.dotX() = mrfZones.faceU();

**************************************************

In numericFlux.H:

.....
const surfaceVectorField& dotX() const //virtual
{
return dotX_;
}

surfaceVectorField& dotX()
{
return dotX_;
}
....

**************************************************

In numericFlux.C:

template<class Flux, class Limiter>
Foam::numericFlux<Flux, Limiter>::numericFlux
(
const volScalarField& p,
const volVectorField& U,
const volScalarField& T,
basicThermo& thermo
)
:
numericFluxBase<Flux>(p.mesh()),
p_(p),
U_(U),
T_(T),
thermo_(thermo),
rhoFlux_
(
....
),
rhoUFlux_
(
...
),
rhoEFlux_
(
...
),
dotX_
(
IOobject
(
"dotX",
this->mesh().time().timeName(),
this->mesh(),
IOobject::NO_READ,
IOobject::NO_WRITE
),
this->mesh(),
dimensionedVector("zero", dimVelocity, vector::zero)
)

{}

**************************************************

In MRFZone.C :
void Foam::MRFZone::faceU
(
surfaceVectorField& zoneFaceU
) const
{
...
}

**************************************************
In MRFZones.C :
Foam::tmp<Foam::surfaceVectorField> Foam::MRFZones::faceU() const
{
tmp<surfaceVectorField> tMRFZonesFaceU
(
new surfaceVectorField
(
...
)
);
surfaceVectorField& MRFZonesFaceU = tMRFZonesFaceU();

forAll(*this, i)
{
operator[](i).faceU(MRFZonesFaceU);
}

return tMRFZonesFaceU;
}


I shall be greatly helped if the error gets resolved and can proceed further. Thanks a lot for your time.


Bidesh

[raumpolizei]

Have you tried to just pass the return argument of faceU() to a field? Might be less efficient but lets try to understand the problem first.

{
surfaceVectorField faceU = mrfZones.faceU()
dbnsFlux.dotX() = faceU;
}

[BSengupta]

Originally Posted by raumpolizei

Have you tried to just pass the return argument of faceU() to a field? Might be less efficient but lets try to understand the problem first.

{
surfaceVectorField faceU = mrfZones.faceU()
dbnsFlux.dotX() = faceU;
}

Hi,


Thanks a lot for your reply and suggestion. I tried the method you suggested but getting the same error.

BSTurboFoam.C:129:19: error: passing ‘const surfaceVectorField {aka const Foam::GeometricField<Foam::Vector<double>, Foam::fvsPatchField, Foam::surfaceMesh>}’ as ‘this’ argument discards qualifiers [-fpermissive]
   dbnsFlux.dotX() = faceU;

Can it be due to the following part in
In numericFlux.C

template<class Flux, class Limiter>
Foam::numericFlux<Flux, Limiter>::numericFlux
(
const volScalarField& p,
const volVectorField& U,
const volScalarField& T,
basicThermo& thermo
)
:
numericFluxBase<Flux>(p.mesh()),
p_(p),
U_(U),
T_(T),
thermo_(thermo),
rhoFlux_
(
IOobject
(
"phi",
this->mesh().time().timeName(),
this->mesh(),
IOobject::NO_READ,
IOobject::NO_WRITE
),
(linearInterpolate(thermo_.rho()*U_) & this->mesh().Sf())
),
rhoUFlux_
(
IOobject
(
"rhoUFlux",
this->mesh().time().timeName(),
this->mesh(),
IOobject::NO_READ,
IOobject::NO_WRITE
),
rhoFlux_*linearInterpolate(U_)
),
rhoEFlux_
(
IOobject
(
"rhoEFlux",
this->mesh().time().timeName(),
this->mesh(),
IOobject::NO_READ,
IOobject::NO_WRITE
),
rhoFlux_*linearInterpolate(thermo.Cv()*T_ + 0.5*magSqr(U_))
),
dotX_
(
IOobject
(
"dotX",
this->mesh().time().timeName(),
this->mesh(),
IOobject::NO_READ,
IOobject::NO_WRITE
),
this->mesh(),
dimensionedVector("zero", dimVelocity, vector::zero)
)

{}
...

I think seeing this error, dotX is not properly defined as const function. I have defined dotX in numericFlux.H as:

virtual const surfaceVectorField& dotX() const
{
return dotX_;
}

Thanks a lot for your time.