[pfavreau]

Yeah ! It works. Thank you, and I hope this version will be implemented in the next release of OpenFOAM, it's really a great work !

Best regards,

Peter

[floquation]

Originally Posted by pfavreau

Yeah ! It works. Thank you, and I hope this version will be implemented in the next release of OpenFOAM, it's really a great work !

Best regards,

Peter

It is already working for you, but for your future reference: I have updated the library with updated instructions.
I could not maintain binary compatibility, hence it is mandatory to recompile your solver. Luckily, this can be done without making any changes to the solver.
I have written a script that can automatically recompile any solver for you, which is located in the "recompileSolvers" directory. See the updated README for instructions.

[miao568666]

Is there an OF-5.0 version available?

Originally Posted by floquation

Have a look at the following.


OF-4.x implementation of 'vofsmooth':
I have implemented Duong's "vofsmooth" in OF-4.x.
It was implemented using OF's run-time selection mechanism and a dynamic library trick, such that it should work with any solver (that uses OF's libinterfaceProperties.so: inter(DyM)Foam, compressibleInter(DyM)Foam, multiphaseInter(DyM)Foam, interPhaseChange(DyM)Foam and very likely some more.)
[Disclaimer: I have only tried inter(DyM)Foam in my work.]

See the README.md on GitHub:
https://github.com/floquation/OF-kva...faceProperties

[floquation]

Originally Posted by miao568666

Is there an OF-5.0 version available?

I did not yet know OF-5.0 was released.

I have just adapted the code to work with OF-5.0 for you (and others) and pushed it to the same GitHub page. Make sure to checkout the branch "of50", as is now also mentioned in the updated README file.

[miao568666]

This is awesome! Thanks Kevin.

Originally Posted by floquation

I did not yet know OF-5.0 was released.

I have just adapted the code to work with OF-5.0 for you (and others) and pushed it to the same GitHub page. Make sure to checkout the branch "of50", as is now also mentioned in the updated README file.

[miao568666]

Hi Kevin,

May I get your advice on how to adapt old version Openfoam codes to newest version? I know it's not easy. But any general instructions are very helpful.

Originally Posted by floquation

I did not yet know OF-5.0 was released.

I have just adapted the code to work with OF-5.0 for you (and others) and pushed it to the same GitHub page. Make sure to checkout the branch "of50", as is now also mentioned in the updated README file.

[floquation]

Originally Posted by miao568666

Hi Kevin,

May I get your advice on how to adapt old version Openfoam codes to newest version? I know it's not easy. But any general instructions are very helpful.

Put two similar codes from both the old and new version next to each other.
For example, if you have a custom solver based on interFoam in 2.1.x, then I'd open the real interFoam of 2.1.x and the interFoam of the new version.
Then by first comparing Make/options and then each individual source file of those two interFoams, I can figure out how to adapt my code to the new version.

[miao568666]

Thanks Kevin for these wonderful advices! I will try out.

Originally Posted by floquation

Put two similar codes from both the old and new version next to each other.
For example, if you have a custom solver based on interFoam in 2.1.x, then I'd open the real interFoam of 2.1.x and the interFoam of the new version.
Then by first comparing Make/options and then each individual source file of those two interFoams, I can figure out how to adapt my code to the new version.

[miao568666]

Originally Posted by floquation

Put two similar codes from both the old and new version next to each other.
For example, if you have a custom solver based on interFoam in 2.1.x, then I'd open the real interFoam of 2.1.x and the interFoam of the new version.
Then by first comparing Make/options and then each individual source file of those two interFoams, I can figure out how to adapt my code to the new version.

Hi Kevin, after I removed this library, Openfoam still asked me to set curvatureModel when using interFoam, how to avoid this problem?

[floquation]

Originally Posted by miao568666

Hi Kevin, after I removed this library, Openfoam still asked me to set curvatureModel when using interFoam, how to avoid this problem?

What exactly did you do to remove it?
If OF is asking you to set "curvatureModel", the library is not removed.
You should remove the .so file from the directory $FOAM_USER_LIBBIN.

[miao568666]

Originally Posted by floquation

What exactly did you do to remove it?
If OF is asking you to set "curvatureModel", the library is not removed.
You should remove the .so file from the directory $FOAM_USER_LIBBIN.

Thanks Kevin, I did as what you said, it works, thanks!

[saddy]

Hey Kevin
i saw your discussions on VOF smoothing and i see you 've been working on boiling flows.
i am also working on boiling and i am using intercondensatingevaporatingfoam solver
from OPENFOAM-V1612+ from ESI
I hve added dynamic meshing to it
it's however plagued with spurious currents.
can you please add vof smoothing for openfoam-v1612+ ?? add support for OPENFOAM ESI
my intercondensatinngevaporatingfoam is attached in this forum...
i'll send you the link if you want to try...

[JSR]

Dear all,
I m also validating two phase slug flow in T junction microreactor using interFoam with constantContactAngle of 140 and so on.......till now results matches nicely till slug breaking mechanism....but after that as slug move in main channel it start accelerating and its size increases till outlet comes......what is the issue,I am stuck now (by observation as one phase block other phase at junction and then it break slug, the slug in main channel accelerates)

I think someone can understand my issue....

[mikebham669]

Originally Posted by floquation

I did not yet know OF-5.0 was released.

I have just adapted the code to work with OF-5.0 for you (and others) and pushed it to the same GitHub page. Make sure to checkout the branch "of50", as is now also mentioned in the updated README file.

Hi Kevin,

for some reason I cannot run ./Allget. At first there was an error saying wrong directory. I have figured that my sh was in bin/sh rather than usr/bin/sh.
Now when I run it I get error from line 33 that "(" is unexpected and pretty much all the other brackets in line 33 and 34. I am pretty sure they should be there and even after removing them I get a syntax error that line 42 "(" is unexpected (expecting "done"). This is seriously doing my head in...

[floquation]

Originally Posted by mikebham669

Hi Kevin,

for some reason I cannot run ./Allget. At first there was an error saying wrong directory. I have figured that my sh was in bin/sh rather than usr/bin/sh.
Now when I run it I get error from line 33 that "(" is unexpected and pretty much all the other brackets in line 33 and 34. I am pretty sure they should be there and even after removing them I get a syntax error that line 42 "(" is unexpected (expecting "done"). This is seriously doing my head in...

I can ensure you that the script works for me, so especially the brackets should be correct.
First try executing the script by explicitly specifying the running environment (from the directory that contains the script):

sh ./Allget

If that doesn't work, what version of sh do you have?

sh --version

The script was written to work with bash. If you have a different shell (like kcsh), then the script has never been checked whether it is compatible. Try executing it explicitly using bash (if your machine has it):

bash ./Allget

As alternative: you don't need the script to use my library. It is just a convenience thing. In the README on GitHub I also wrote instruction to install my library without the Allget script.
In fact, all that Allget does is use your "list_of_solvers" file to repetitively call the getSolverMake.sh script for all solvers you wish to recompile. You can do that by hand as well (see the README on GitHub).
Then, getSolverMake.sh (I hope that one works for you) modifies some files of the solver like Make/files and Make/options to automagically link it against my library, and set its compilation location to $FOAM_USER_APPBIN: the place where custom solvers should go.

Hope that helps you.

[O'nel]

Hey Kevin and Michal,

first of thanks a lot for the port and your detailed description on github Kevin!
I ran into the same problem that Michal had and managed to fix it, simply by replacing the first line:

#! /usr/bin/sh

with:

#!/bin/bash

in the Allget, Allwmake and the getSolverMake.sh script.

I hope this is helpful for other foamers out there.

Best regards,
Leon

[floquation]

Originally Posted by O'nel

#! /usr/bin/sh

with:

#!/bin/bash

Thank you for putting that out here.
In the meantime I'd run into the same problem with a student of mine who wanted to use his own laptop as well, for which we used that same solution.

I just wonder what the "proper" Linux way of writing the shebang is... Perhaps using env?

/usr/bin/env bash

[dzordz]

Hi Kevin,

Theoretically, it should work with any OF solver that relies on OF's interfaceProperties, as kva_interfaceProperties merely overrides OF's interfaceProperties' behaviour:

I have a question regarding the multiphaseInterFoam solver, which you say it is compatible with kva_interfaceProperties. I find this not to be true, since the curvature calculation is not being done in interfaceProperties.C (like interFoam), but instead in multiphaseMixture.C. Compilation with recompile solver is done without error.



Also the compressibleInterFoam compiles without error. Then it gives an error: keyword water in not defined in the dictionary thermophysicalProperties. Solution: Phases and propreties need to be added there, since the code calls for rho1_ and rho2_ in order to use densityWeighted model. Am I assuming correct that if the model is turned off these values could be arbitrary and will not affect the calculations?


I might be getting something wrong in how your code is implemented though. Any thoughts?

Thanks

[stardust111]

Dear Kevin,
Thank you very much for sharing your code. It was really useful for my project.
However, now I met a problem when compiling it to the compressibleInterFoam:
compressibleInterFoam.C:46:35: fatal error: twoPhaseMixtureThermo.H: No such file or directory
Do you have any clue to solve this? Thanks a lot.P.S.: I have successfully compiled the interFoam solver with your code without any error.P.S.2: I have both OF40 and OF50 on my computer, both have the same problem.
best
Guang

[dzordz]

Originally Posted by stardust111

Dear Kevin,
Thank you very much for sharing your code. It was really useful for my project.
However, now I met a problem when compiling it to the compressibleInterFoam:
compressibleInterFoam.C:46:35: fatal error: twoPhaseMixtureThermo.H: No such file or directory
Do you have any clue to solve this? Thanks a lot.P.S.: I have successfully compiled the interFoam solver with your code without any error.P.S.2: I have both OF40 and OF50 on my computer, both have the same problem.
best
Guang

I had the same issue with this compilation. For some reason linking in Make/options file to this twoPhaseMixtureThermo folder fails. What solved my problem (probably not smoothest solution) is adding an additional line in options -I/.....path to twoPhaseMixtureThermo folder.... \


Hope it helps.