[shock77]

Hello all,


the long version of the problem is described in this thread: Wrong Solution for sensibleEnthalpy
I could reconstruct this case and it seems, that rhoCentralFoam only works with sensibleInternalEnergy as energy variable and not with internalEnthalpy. I also used the sod shock tube.
I tried to figure out the problem. Since I am not an expert on C++, I would like to hear your opinion.

I think the problem is, that enthalpy h is assumed to be equal to internal energy e, which is not correct, but for incompressible flow the assumption is okay, like Bloerb described it in the thread meantioned above. The bug report https://bugs.openfoam.org/view.php?id=571 also mentioned this problem. I am struggling to find this issue in the code and maybe someone can help me out.

The energy variable e used in rhoCentralFoam is defined as:

volScalarField& e = thermo.he();

in applications/solvers/compressible/rhoCentralFoam/rhoCentralFoam.C/createFields.H


Further, he is derived from:

  
 template<class Thermo, template<class> class Type>

 inline Foam::scalar

 Foam::species::thermo<Thermo, Type>::he(const scalar p, const scalar T) const

 {

     return this->HE(p, T)*this->W();

 }

in src/thermophysicalModels/specie/thermo/thermo/thermoI.H



HE is derived from

            // Sensible enthalpy [J/kg]

             scalar HE

             (

                 const Thermo& thermo,

                 const scalar p,

                 const scalar T

             ) const

             {

                 return thermo.Hs(p, T);

             }

In src/thermophysicalModels/specie/thermo/sensibleEnthalpy/sensibleEnthalpy.H


Hs is derived from:

 template<class EquationOfState>

 inline Foam::scalar Foam::hConstThermo<EquationOfState>::Hs

 (

     const scalar p, const scalar T

 ) const

 {

     return Cp_*T + EquationOfState::H(p, T);

 }

in src/thermophysicalModels/specie/thermo/hConst/hConstThermoI.H


This concludes: e=cp*T, which is wrong. It is easily tricked by specifying for Cp the value of Cv. I tried it and it produced the right answers.


Thoughts? Did I make a mistake?