[sinatahmooresi]

hi friends!
i want to add in concentration fields (S) and temperature(T) in to pisoFoam and i also i want to define a new formula for calculation of rho that is function of both S,T that is named Mille and Poisson (1981) equation of density. so i want to define this in pisoFoam.c and i compile it . and another changing is to a modification in momentum equation. so i did these to pisofoam.c and also i introduced S , T to creatField.H .

in pisoFoam.c:

rho==1000;
rho==(rho/1000*(999.842594+6.793952e-2*T-(9.095290e-3*pow(T,2))+
(1.001685e-4*pow(T,3))-(1.120083e-6*pow(T,4))+(6.536336e-9*pow(T,5))+
S*(8.24493e-1-4.0899e-3*T+(7.6438e-5*pow(T,2))-(8.2467e-7*pow(T,3))+
(5.3875e-9*pow(T,4)))+(pow(S,1.5))*(-5.72466e-3+1.0227e-4*T-1.6546e-6*pow(T,2))+S*(4.8314e-4)));


and in momentum equation:
fvVectorMatrix UEqn
(
fvm::ddt(U)
+ fvm::div(phi, U)
+ turbulence->divDevReff(U)
-g*(rho-1000)/1000
);

UEqn.relax();


fvScalarMatrix SEqn
(
fvm::ddt(rho, S)
+ fvm::div(rhophi, S)
- fvm::laplacian(kappaEff, S)
);

SEqn.relax();
SEqn.solve();

fvScalarMatrix TEqn
(
fvm::ddt(rho, T)
+ fvm::div(rhophi, T)
- fvm::laplacian(kappaEff, T)
);

TEqn.relax();
TEqn.solve();

so when i want to compile this, i face with some errors:

my_pisoFoam.C:65:2: error: ‘rho’ was not declared in this scope
my_pisoFoam.C:76:16: error: ‘g’ was not declared in this scope
my_pisoFoam.C:91:26: error: ‘rhophi’ was not declared in this scope
my_pisoFoam.C:92:32: error: ‘kappaEff’ was not declared in this scope

i should say that i changed the name of modified solver to my_pisoFoam.
i know that in creatField.H of pisoFoam there is now any definition of "transport properties" and for exapmle kappaEff is one of constants that i introduced in transport properties directory like others that are in this directoru by defaults. i hope to my friends in FOAM can understand my question well!!!
all the bests
thank u all

[rapierrz]

Hi sina,

Please attach your solver.

[sinatahmooresi]

hi friend!
i attached my modified solver to this reply
any help is appreciated.
thank u

[rapierrz]

Originally Posted by sinatahmooresi

hi friend!
i attached my modified solver to this reply
any help is appreciated.
thank u

In your code,you don't define rho,rhoPhi,kappaEffec,... in createField.H.

You must define every variable that use in your code in createField or in

.C file.

And you should call gravitationalAcceleration.H in your headers for g.

[sinatahmooresi]

Hi rapierrz!
i added #include "readGravitationalAcceleration.H" to fix problem of "g" and i added "Reading transportProperties\n" to fix problem of "kappaEff" and i added :
surfaceScalarField rhoPhi
(
IOobject
(
"rho*phi",
runTime.timeName(),
mesh,
IOobject::NO_READ,
IOobject::NO_WRITE
),
linearInterpolate(rho) * phi
);

to fix "rhophi" problem .
i copied that rhophi from creatField.H of inetrFoam solver
so i compiled the solver again and the only error masege that i faced is :
make: *** [Make/linux64GccDPOpt/my_pisoFoam.o] Error 1
and as u saw the solver i defined "S" and "T" fields and it is conventional to reading fields at first like
reading field P
reading field U ,...
so i'm expecting to see reading field S and T
but it doesn't occur unfortunately !
i attached it again
thanks for your guidance

[sinatahmooresi]

i missed to attach solver in previous reply

[sinatahmooresi]

i think there is a problem to attachment ! i'm trying my_pisoFoam (copy).tar.gz

[rapierrz]

Originally Posted by sinatahmooresi

Hi rapierrz!
i added #include "readGravitationalAcceleration.H" to fix problem of "g" and i added "Reading transportProperties\n" to fix problem of "kappaEff" and i added :
surfaceScalarField rhoPhi
(
IOobject
(
"rho*phi",
runTime.timeName(),
mesh,
IOobject::NO_READ,
IOobject::NO_WRITE
),
linearInterpolate(rho) * phi
);

to fix "rhophi" problem .
i copied that rhophi from creatField.H of inetrFoam solver
so i compiled the solver again and the only error masege that i faced is :
make: *** [Make/linux64GccDPOpt/my_pisoFoam.o] Error 1
and as u saw the solver i defined "S" and "T" fields and it is conventional to reading fields at first like
reading field P
reading field U ,...
so i'm expecting to see reading field S and T
but it doesn't occur unfortunately !
i attached it again
thanks for your guidance

Hi sina,

Please,put your full error massage.

[sinatahmooresi]

Hi rapierrz,
that error message that i put here is the last line of compiling! and before it there is some warning messages that I've seen in other compilation before. in this case before the last line that it contains the error some lines are :

/opt/openfoam221/src/OpenFOAM/lnInclude/VectorSpaceI.H:634:13: note: template<class Form, class Cmpt, int nCmpt> bool Foam:perator==(const Foam::VectorSpace<Form, Cmpt, nCmpt>&, const Foam::VectorSpace<Form, Cmpt, nCmpt>&)
/opt/openfoam221/src/finiteVolume/lnInclude/readPISOControls.H:3:15: warning: unused variable ‘nOuterCorr’ [-Wunused-variable]
/opt/openfoam221/src/finiteVolume/lnInclude/readPISOControls.H:15:16: warning: unused variable ‘transonic’ [-Wunused-variable]
make: *** [Make/linux64GccDPOpt/my_pisoFoam.o] Error 1
thanks for your attentions

[rapierrz]

Hi sina,

In your code,there are a lots of errors and ill defined parameters.

before you start to write your own code,you should start with simple case

such as add temperature to icoFoam:

https://openfoamwiki.net/index.php/H...ure_to_icoFoam

with this manner you can add S and T fields to your code.

also,you should read about units and mathematical operators in openfoam.

good luck.

[sinatahmooresi]

Hi friend
actually i read that one (how to add temperature field to icoFoam) i'm learnig FOAM. bur as u read the code before! was it full of ill defined parameters and so on ?!!
thanks a lot for your attentions