CFD Online Logo CFD Online URL
www.cfd-online.com
[Sponsors]
Home > Forums > Software User Forums > OpenFOAM > OpenFOAM Programming & Development

Difference in computation of "e" and "wallHeatFlux" between v6 and v6-patched

Register Blogs Members List Search Today's Posts Mark Forums Read

Reply
 
LinkBack Thread Tools Search this Thread Display Modes
Old   November 26, 2019, 11:23
Default Difference in computation of "e" and "wallHeatFlux" between v6 and v6-patched
  #1
Senior Member
 
Deep
Join Date: Oct 2017
Posts: 180
Rep Power: 4
deepbandivadekar is on a distinguished road
Hello,

I noticed that the heat flux on the wall differed when I ran a case in v6 (or v5) and the patched v6. On further investigation I noticed that the residuals for "e" in the log were different from step 1. So it looks like when v6 was patched, somewhere, something was changed that affected energy computations. I wanted to know exactly what has changed in these two versions. I need to know exactly which version is correct and why.

I'm trying to create a simpler case to show you a comparison. However, I'm looking for any direction wrt how to approach finding cause for such differences.

1. I have looked at the changelog for each new patch for v6 and found nothing that could be directly related to this.
2. I tried to compare the /src/ for both versions but it's a real pain because of irrelevant differences like added comments or changes from "small" to SMALL" etc. Is there a better way to approach this? Is it possible to narrow down the possible locations for this comparison?

Thanks
deepbandivadekar is offline   Reply With Quote

Old   November 26, 2019, 11:51
Default
  #2
Member
 
Hosein
Join Date: Nov 2011
Location: Germany
Posts: 81
Rep Power: 10
einstein_zee is on a distinguished road
Hey there,

well, if you considered v6 with applied commits on github as "patched v6" then you may start to look for it on "commits" section for v6. For each commit also you may find a description as a reason for the change.
einstein_zee is offline   Reply With Quote

Old   November 26, 2019, 12:09
Default
  #3
Senior Member
 
Deep
Join Date: Oct 2017
Posts: 180
Rep Power: 4
deepbandivadekar is on a distinguished road
Quote:
Originally Posted by einstein_zee View Post
Hey there,

well, if you considered v6 with applied commits on github as "patched v6" then you may start to look for it on "commits" section for v6. For each commit also you may find a description as a reason for the change.
Oh well! I was going to reply saying I have already been through them but just thought of revisiting, in case if I had missed something. And indeed I had.

They fixed this in one of the patches: https://bugs.openfoam.org/view.php?id=3025

So the v6 unpatched is wrong at least for rhoCentralFoam.


Okaydokes.
deepbandivadekar is offline   Reply With Quote

Reply

Tags
energy, version-specific code, wallheatflux

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are On
Refbacks are On



All times are GMT -4. The time now is 16:25.