[mturcios777]

Hello all,

I have been updating some old OpenFOAM code (originally in v2, now in v10/11) based on the chemistryModel library where I do a calculation over all cells. I have added the virtual function to basicChemistryModel and the implementation in chemistryModel/chemistryModel.C. I am trying to just do a loop over all cells with a forAll loop, but I only get the first processor to work.

I can't post the full code so I need to create a stub case, but basically (assuming a private member A_ that is a volScalarField that is registered and read in):

template<class ThermoType>
void Foam::chemistryModel<ThermoType>::someFunction()
{
    tmp<volScalarField> trho(this->thermo().rho();
    const volScalarField rho = trho();
    scalar AVolAve = 0;
    scalar totalVol = 0;

   forAll(rho,celli)
   {
        A_[celli] = rho[celli];
        //AVolAve = A_[celli]*this->mesh().V()[celli];
        //totalVol = this->mesh().V()[celli];
   }

    //reduce(AVolAve, sumOp<scalar>());
    //reduce(totalVol, sumOp<scalar>());

    //AVolAve /= totalVol;
    //Info << "Volume averaged A is: " << AVolAve << endl;
}

The code compiles and runs perfectly in serial. When running in parallel, the reduce operations are necessary to ensure code executes on all processors. If I comment out he code as above, only the first processor is updated.

Any assistance would be welcome.

[olesen]

Originally Posted by mturcios777

The code compiles and runs perfectly in serial. When running in parallel, the reduce operations are necessary to ensure code executes on all processors. If I comment out he code as above, only the first processor is updated.

I think that you are much too quick jumping to the wrong conclusion - what makes you think that the code is only being executed on one rank?

If you replace the "Info" statement with "Pout" you will print the values on each rank, which will presumably contradict your conclusion.

[olesen]

Originally Posted by mturcios777

    tmp<volScalarField> trho(this->thermo().rho();
    const volScalarField rho = trho();

This is wasteful to make a full copy of the tmp field, please use a reference:

tmp<volScalarField> trho(this->thermo().rho();
const auto& rho = trho();