[immortality]

thanks.but the error persists:

ehsan@Ehsan-com:~/Desktop/rhoPimpleFoamLimited$ wmake
Making dependency list for source file rhoPimpleFoamLimited.C
SOURCE=rhoPimpleFoamLimited.C ;  g++ -m64 -Dlinux64 -DWM_DP -Wall -Wextra -Wno-unused-parameter -Wold-style-cast -Wnon-virtual-dtor -O3  -DNoRepository -ftemplate-depth-100 -I/opt/openfoam211/src/thermophysicalModels/basic/lnInclude -I/opt/openfoam211/src/turbulenceModels/compressible/turbulenceModel -I/opt/openfoam211/src/finiteVolume/cfdTools -I/opt/openfoam211/src/finiteVolume/lnInclude -IlnInclude -I. -I/opt/openfoam211/src/OpenFOAM/lnInclude -I/opt/openfoam211/src/OSspecific/POSIX/lnInclude   -fPIC -c $SOURCE -o Make/linux64GccDPOpt/rhoPimpleFoamLimited.o
rhoPimpleFoamLimited.C: In function ‘int main(int, char**)’:
rhoPimpleFoamLimited.C:90:85: error: invalid types ‘<unresolved overloaded function type>[Foam::label {aka int}]’ for array subscript
rhoPimpleFoamLimited.C:94:41: error: name lookup of ‘cellI’ changed for ISO ‘for’ scoping [-fpermissive]
rhoPimpleFoamLimited.C:94:41: note: (if you use ‘-fpermissive’ G++ will accept your code)
rhoPimpleFoamLimited.C:100:132: error: ‘Foam::T’ does not have class type
make: *** [Make/linux64GccDPOpt/rhoPimpleFoamLimited.o] Error 1

[immortality]

the code is now:

forAll(U,cellI)
           {
            U[cellI].component(0)=min(U[cellI].component(0), sqrt(1.4*287.14*T[cellI])-30);
           }
           forAll(U,cellJ)
           {
            U[cellJ].component(1)=max(U[cellI].component(1),-150);
           }
         word patchName = "left";
         label patchID = mesh.boundary().findPatchID(patchName);
         forAll(U.boundaryField()[patchID],faceI)
           {
               U.boundaryField()[patchID][faceI].component(0)=min(U.boundaryField()[patchID][faceI].component(0), sqrt(1.4*287.14*T.boundaryField()[patchID][faceI])-30);
               U.boundaryField()[patchID][faceI].component(1)=max(U.boundaryField()[patchID][faceI].component(1),-150);
           }

[immortality]

hi
did you find a reason for this error and not compiling?

[batta31]

Maybe the first error (the one at line 90) is because you are trying to subtract T and the scalar value 30, but I'm not sure about it.


The second error (line 94) it's because you are using [cellI] variable into a loop with [cellJ].

The third (line 100) it's because, probably, you can't write T.boundaryField[patchID][faceI] since, I think, T doesn't have the access class "boundaryField". Try instead

T.boundary[patchID][faceI]

as, for example, happens for the variable p in other solvers.

Hope this helps

Simone

[immortality]

thanks dear Simone.I changed it so:

forAll(U,cellI)
           {
            U[cellI].component(0)=min(U[cellI].component(0), sqrt(1.4*287.14*T[cellI]));
           }
           forAll(U,cellJ)
           {
            U[cellJ].component(1)=max(U[cellJ].component(1),-150);
           }
         word patchName = "left";
         label patchID = mesh.boundary().findPatchID(patchName);
         forAll(U.boundaryField()[patchID],faceI)
           {
               U.boundaryField()[patchID][faceI].component(0)=min(U.boundaryField()[patchID][faceI].component(0), sqrt(1.4*287.14*T.boundary()[patchID][faceI]));
               U.boundaryField()[patchID][faceI].component(1)=max(U.boundaryField()[patchID][faceI].component(1),-150);
           }

but the error:

rhoPimpleFoamLimited.C: In function ‘int main(int, char**)’:
rhoPimpleFoamLimited.C:90:85: error: invalid types ‘<unresolved overloaded function type>[Foam::label {aka int}]’ for array subscript
rhoPimpleFoamLimited.C:100:132: error: ‘Foam::T’ does not have class type
make: *** [Make/linux64GccDPOpt/rhoPimpleFoamLimited.o] Error 1

what's your opinion?

[batta31]

How have you defined T?

[immortality]

it seems it has trouble with T field.I only put it:

forAll(U,cellI)
           {
            //U[cellI].component(0)=min(U[cellI].component(0), sqrt(401.996*T[cellI]));
            U[cellI].component(0)=min(U[cellI].component(0), T[cellI]);
            U[cellI].component(1)=max(U[cellI].component(1),-150);
           }

and showed this error:

rhoPimpleFoamLimited.C: In function ‘int main(int, char**)’:
rhoPimpleFoamLimited.C:91:69: error: invalid types ‘<unresolved overloaded function type>[Foam::label {aka int}]’ for array subscript
make: *** [Make/linux64GccDPOpt/rhoPimpleFoamLimited.o] Error 1

but when all is a number it works well.

[immortality]

it seems it has trouble with T field.I only put it:

forAll(U,cellI)
           {
            //U[cellI].component(0)=min(U[cellI].component(0), sqrt(401.996*T[cellI]));
            U[cellI].component(0)=min(U[cellI].component(0), T[cellI]);
            U[cellI].component(1)=max(U[cellI].component(1),-150);
           }

and showed this error:

rhoPimpleFoamLimited.C: In function ‘int main(int, char**)’:
rhoPimpleFoamLimited.C:91:69: error: invalid types ‘<unresolved overloaded function type>[Foam::label {aka int}]’ for array subscript
make: *** [Make/linux64GccDPOpt/rhoPimpleFoamLimited.o] Error 1

but when all is a number it works well.

[immortality]

it seems it has trouble with T field.I only put it:

forAll(U,cellI)
           {
            //U[cellI].component(0)=min(U[cellI].component(0), sqrt(401.996*T[cellI]));
            U[cellI].component(0)=min(U[cellI].component(0), T[cellI]);
            U[cellI].component(1)=max(U[cellI].component(1),-150);
           }

and showed this error:

rhoPimpleFoamLimited.C: In function ‘int main(int, char**)’:
rhoPimpleFoamLimited.C:91:69: error: invalid types ‘<unresolved overloaded function type>[Foam::label {aka int}]’ for array subscript
make: *** [Make/linux64GccDPOpt/rhoPimpleFoamLimited.o] Error 1

but when all is a number it works well.

[immortality]

oh.it wasn't sending but three of it send at a same time!
what do you mean by defining T?
OF doesn't recognize T field itself?

[batta31]

You are modifying a solver that was already present, right? Check in the associated createFields.H file how is T defined!

And then try to have a look to the access functions that can be used for that particular "T" field.

Cheers
Simone

[immortality]

its total of creatFields.H!
its seemed that T is not defined explicitly in it.
should I add it?like rho?
where can find access functions?

    Info<< "Reading thermophysical properties\n" << endl;

    autoPtr<basicPsiThermo> pThermo
    (
        basicPsiThermo::New(mesh)
    );
    basicPsiThermo& thermo = pThermo();

    volScalarField& p = thermo.p();
    volScalarField& h = thermo.h();
    const volScalarField& psi = thermo.psi();

    volScalarField rho
    (
        IOobject
        (
            "rho",
            runTime.timeName(),
            mesh,
            IOobject::READ_IF_PRESENT,
            IOobject::AUTO_WRITE
        ),
        thermo.rho()
    );

    Info<< "Reading field U\n" << endl;
    volVectorField U
    (
        IOobject
        (
            "U",
            runTime.timeName(),
            mesh,
            IOobject::MUST_READ,
            IOobject::AUTO_WRITE
        ),
        mesh
    );

    #include "compressibleCreatePhi.H"

    dimensionedScalar rhoMax(pimple.dict().lookup("rhoMax"));
    dimensionedScalar rhoMin(pimple.dict().lookup("rhoMin"));

    Info<< "Creating turbulence model\n" << endl;
    autoPtr<compressible::turbulenceModel> turbulence
    (
        compressible::turbulenceModel::New
        (
            rho,
            U,
            phi,
            thermo
        )
    );

    Info<< "Creating field dpdt\n" << endl;
    volScalarField dpdt("dpdt", fvc::ddt(p));

    Info<< "Creating field kinetic energy K\n" << endl;
    volScalarField K("K", 0.5*magSqr(U));

[immortality]

I defined T as:

volScalarField T
    (
        IOobject
        (
            "T",
            runTime.timeName(),
            mesh,
            IOobject::READ_IF_PRESENT,
            IOobject::AUTO_WRITE
        ),
        thermo.T()
    );

in creatFields.H
is it true now?
but another question,how T is written in time folders when it is not defined directly in creatFields.H?

[immortality]

but the error now is:

ehsan@Ehsan-com:~/Desktop/rhoPimpleFoamLimited$ wmake
Making dependency list for source file rhoPimpleFoamLimited.C
SOURCE=rhoPimpleFoamLimited.C ;  g++ -m64 -Dlinux64 -DWM_DP -Wall -Wextra -Wno-unused-parameter -Wold-style-cast -Wnon-virtual-dtor -O3  -DNoRepository -ftemplate-depth-100 -I/opt/openfoam220/src/thermophysicalModels/basic/lnInclude -I/opt/openfoam220/src/turbulenceModels/compressible/turbulenceModel -I/opt/openfoam220/src/finiteVolume/cfdTools -I/opt/openfoam220/src/finiteVolume/lnInclude -I/opt/openfoam220/src/meshTools/lnInclude -I/opt/openfoam220/src/sampling/lnInclude -I/opt/openfoam220/src/fvOptions/lnInclude -IlnInclude -I. -I/opt/openfoam220/src/OpenFOAM/lnInclude -I/opt/openfoam220/src/OSspecific/POSIX/lnInclude   -fPIC -c $SOURCE -o Make/linux64GccDPOpt/rhoPimpleFoamLimited.o
rhoPimpleFoamLimited.C: In function ‘int main(int, char**)’:
rhoPimpleFoamLimited.C:94:83: error: call of overloaded ‘sqrt(double)’ is ambiguous
rhoPimpleFoamLimited.C:94:83: note: candidates are:
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:157:1: note: double sqrt(double)
/opt/openfoam220/src/OpenFOAM/lnInclude/dimensionedScalar.H:65:19: note: Foam::dimensionedScalar Foam::sqrt(const dimensionedScalar&)
/opt/openfoam220/src/OpenFOAM/lnInclude/Scalar.H:258:1: note: Foam::doubleScalar Foam::sqrt(Foam::doubleScalar)
/opt/openfoam220/src/OpenFOAM/lnInclude/Scalar.H:258:1: note: Foam::floatScalar Foam::sqrt(Foam::floatScalar)
rhoPimpleFoamLimited.C:106:161: error: call of overloaded ‘sqrt(double)’ is ambiguous
rhoPimpleFoamLimited.C:106:161: note: candidates are:
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:157:1: note: double sqrt(double)
/opt/openfoam220/src/OpenFOAM/lnInclude/dimensionedScalar.H:65:19: note: Foam::dimensionedScalar Foam::sqrt(const dimensionedScalar&)
/opt/openfoam220/src/OpenFOAM/lnInclude/Scalar.H:258:1: note: Foam::doubleScalar Foam::sqrt(Foam::doubleScalar)
/opt/openfoam220/src/OpenFOAM/lnInclude/Scalar.H:258:1: note: Foam::floatScalar Foam::sqrt(Foam::floatScalar)
make: *** [Make/linux64GccDPOpt/rhoPimpleFoamLimited.o] Error 1

what do you think about this?
thank you.

[immortality]

what is incorrect in T now?I've defined it.
Another question is if this limiting true in aspect of CFD results?i mean does it lead to correct results with limiting?whats its influence in your opinion?

[immortality]

did anyone find a reason and solution of the problem?

[ngj]

I believe it would help if you put

Foam::

in front of your "sqrt" operation.

Kind regards,

Niels

[immortality]

thank you very very so much dear Niels!!
it resolved.
may you tell me the reason?is the sqrt a class object?
how could i find the access functions for fields?

[ngj]

It is my understand that the compiler does not know, whether to use the std:: or Foam:: class definition of sqrt, since the Foam:: is probably derived from std::.

Kind regards,

Niels

[immortality]

i have a subsonic problem but velocity at early time steps goes higher than sonic velocity and so i've limited it to sonic values as you can see above.
I have a doubt about the effect of this work on last results.
Because running takes much time i decided to ask first.
The CFD problem is unsteady compressible if important.