[elBombastico]

Dear all,


I am stuck implementing a new thermodynamic model that includes a transport model (mu, kappa), an EOS and a thermodynamic model (Cp) from rhoThermo (OF8). On top of that, I am replacing the Newton-Raphson routine that calculates the temperature from the enthalpy by another method. My problem is, I am not able to figure out how to modify the files (and which ones) that tell OF by which sub-models the new model is conformed. I also have some doubts about how I should compile it.


So far, I am doing the following:

1. I copy src/thermophysicalModels/specie and basic to my user folder respecting the folder structure.
2. I copy the content of src/thermophysicalModels/basic/rhoThermo to a folder with the name of my model and rename all the rhoThermo and heRhoThermo instances to the model name e.g. myRhoThermo and myHeRhoThermo. In the new folder, I also delete liquidThermo.C and .H.
3. I place, in species/transport, species/equationOfState and species/thermo, the files that include the calculations of kappa, mu, rho and Cp.
4. I place, in species/thermo/thermo, the files that do the temperature calculation as I want to (one thermo.C, one thermo.H and one thermoI.H).

Now I have to tell OF that my new thermo model is consituted by the transport, EOS, and thermo sub-models that I have implemented, and this is also where my problems start. Up to OF7, this was done via files called "thermoPhysicsTypes.H", and "rhoThermos.C". "thermoPhysicsTypes.H" contained all the possible thermophysical model combinations (including the pre-defined ones), and was removed from OF8. It seems to have been replaced by "typedefThermo.H". "rhoThermos.C" is very different from the one in previous versions. On top of that, the specie/include folder contains, together with "typedefThermo.H", a fair amount of files called forAbsoluteGases.H, forLiquids.H.... plus forThermo.H, and makeThermo.H.



Finally, I compile the specie and basic folders. Compilation of the latter does not go through. Rather than posting the error message, I have these questions:

1. Are typedefThermo.H and myRhoThermos.C where I have to do these modifications?
2. Do I actually need all the forLiquids.H, forAbsoluteGases.H etc ? I suspect I do not .
3. Do you have an example of how I should modify these files and/or can you give me a clue about how to do it?
4. Am I allowed to include in the basic/make/files only the .C files of the new model?

All the information/tutorials I found (e.g. this and this) belong to OF7 latest, where the file structure was different, or do not give the amount of detail that would help me.

I found some thermo models in gitHub, but either they are for older versions, or do not include the specie folder. If I succeed, I am willing to write a tutorial and post it in the wiki, or in the place of your suggestion.


I have attached rhoThermos.C (OF8), rhoThermos.C (OF7), plus the content of specie/include folder.


I am sorry if this kind of modification is very basic. I am not very familiar with either OF directory structure or C++.


Thanks in advance for your help